a11y atspi: Drop FIXME that doesn't need action

The reply *is* needed.

Otherwise, e.g. running
examples/widgets/widgets/spinboxes/spinboxes
and clicking on the a11y objects for the spinboxes
in Accerciser's [1] treeview of the app's a11y
hierarchy makes Accerciser output this and crash:

> $ accerciser
> dbus[67434]: arguments to dbus_message_unref() were incorrect, assertion "message != NULL" failed in file ../../../dbus/dbus-message.c line 1727.
> This is normally a bug in some application using the D-Bus library.
>
>   D-Bus not built with -rdynamic so unable to print a backtrace
> Aborted (core dumped)

[1] https://gitlab.gnome.org/GNOME/accerciser

diff --git a/src/gui/accessible/linux/atspiadaptor.cpp b/src/gui/accessible/linux/atspiadaptor.cpp
index cdc27132c9..6b8a9fcaac 100644

Change-Id: I442d3130623ccae096a6b79577874a6fd95c8aa2
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
This commit is contained in:
Michael Weghorn 2022-08-19 10:15:58 +02:00
parent e5dca1ebe3
commit e81e7c3d99

View File

@ -2288,7 +2288,7 @@ bool AtSpiAdaptor::valueInterface(QAccessibleInterface *interface, const QString
//Temporary fix
//See https://bugzilla.gnome.org/show_bug.cgi?id=652596
valueIface->setCurrentValue(value);
connection.send(message.createReply()); // FIXME is the reply needed?
connection.send(message.createReply());
} else {
QVariant value;
if (function == "GetCurrentValue"_L1)