From e684a7a159ef889a9bc11b59d111dd4325281baf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kai=20K=C3=B6hne?= Date: Fri, 2 Jun 2023 16:35:22 +0200 Subject: [PATCH] CMake: Remove local __PPS target Remove the local __PPS target and make PPS::PPS itself the imported target. This is not only simpler, but also hopefully resolves an issue with static builds, where PPS::PPS was not properly promoted to a global target, leading to linker errors. Fixes: QTBUG-108794 Change-Id: Ia9334a27312ba9bfeec964f6bd6a82652e5f9d37 Reviewed-by: Alexandru Croitor (cherry picked from commit b63bf9832959fbb9fb9b6f1546366e582d5c1f36) Reviewed-by: Qt Cherry-pick Bot --- cmake/FindPPS.cmake | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cmake/FindPPS.cmake b/cmake/FindPPS.cmake index 6556091c11e..099019243ce 100644 --- a/cmake/FindPPS.cmake +++ b/cmake/FindPPS.cmake @@ -18,9 +18,7 @@ find_package_handle_standard_args(PPS DEFAULT_MSG PPS_INCLUDE_DIR PPS_LIBRARY) mark_as_advanced(PPS_INCLUDE_DIR PPS_LIBRARY) if(PPS_FOUND) - add_library(__PPS INTERFACE IMPORTED) - target_link_libraries(__PPS INTERFACE "${PPS_LIBRARY}") - target_include_directories(__PPS INTERFACE "${PPS_INCLUDE_DIR}") - - add_library(PPS::PPS ALIAS __PPS) + add_library(PPS::PPS INTERFACE IMPORTED) + target_link_libraries(PPS::PPS INTERFACE "${PPS_LIBRARY}") + target_include_directories(PPS::PPS INTERFACE "${PPS_INCLUDE_DIR}") endif()