1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QSqlTableModel::setData(): comment historical idiosyncracies

Browse Source 
Change-Id: I5c4782e18dc7a471dc294a4146db04f1efd3ed2e
Reviewed-by: Yunqiao Yin <charles.yin@nokia.com>
This commit is contained in:
Mark Brand 2011-07-07 12:42:07 +02:00 committed by Qt by Nokia
parent f6e3f24683
commit e5c8927fe8
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/models/qsqltablemodel.cpp
View File

@ -494,11 +494,25 @@ bool QSqlTableModel::setData(const QModelIndex &index, const QVariant &value, in
bool isOk = true;
if (d->strategy == OnFieldChange && row.op != QSqlTableModelPrivate::Insert) {
// historical bug: bad style to call updateRowInTable.
// Should call submit(), but maybe the author wanted to avoid
// clearing the cache on failure.
isOk = updateRowInTable(index.row(), row.rec);
if (isOk)
select();
}
// historical bug: dataChanged() is suppressed for OnFieldChange and OnRowChange
// when operating on an "insert" record. This is to accomodate
// applications that call setData() while handling primeInsert().
// Otherwise dataChanged() would be emitted between beginInsert()
// and endInsert().
// The price of this workaround is that, although the view making
// the change will already display the new value, other views connected
// to the model probably will not.
// It's not clear why OnManualSubmit is excluded from this workaround.
// Calling setData() while handling primeInsert() is arguably very wrong anyway.
// primeInsert() provides a ref to the record for settings values.
if (d->strategy == OnManualSubmit || row.op != QSqlTableModelPrivate::Insert)
emit dataChanged(index, index);