1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SQL/PSQL: slight improvement in code

Browse Source 
added a details about code paths that cannot happen and added constexpr

Fixes: QTBUG-132303
Pick-to: 6.9
Change-Id: I98340c5a1f275c00aafb3294cf8e5e8368126b76
Reviewed-by: Christian Ehrlicher <ch.ehrlicher@gmx.de>
This commit is contained in:
Thierry Bastian 2025-01-27 08:25:55 +01:00
parent 61dbdbeb31
commit e574cda7fc
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/sqldrivers/psql/qsql_psql.cpp
View File

@ -1462,7 +1462,10 @@ QSqlRecord QPSQLDriver::record(const QString &tablename) const
template <bool forPreparedStatement>
inline QString autoQuoteResult(QAnyStringView str)
{
return forPreparedStatement ? str.toString() : (u'\'' + str.toString() + u'\'');
if constexpr (forPreparedStatement)
return str.toString();
else
return u'\'' + str.toString() + u'\'';
}
template <bool forPreparedStatement, class FloatType>
@ -1512,8 +1515,8 @@ QString QPSQLDriver::formatValue(const QSqlField &field, bool trimStrings) const
break;
}
case QMetaType::QString:
if (forPreparedStatement) {
r = field.value().toString();
if constexpr (forPreparedStatement) {
r = field.value().toString(); // there is no code path where trimStrings can be true here
} else {
r = QSqlDriver::formatValue(field, trimStrings);
if (d->hasBackslashEscape)