1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QStringApiSymmetry: fix a typo and deal with the fallout

Browse Source 
Turns out we don't support QStringView/QUtf8StringView comparison, and
the only reason the corresponding test succeeded was because it
contained a typo (QStringView instead of QUtf8StringView).

Fix the typo and disable the now-failing test.

Change-Id: I2210a247aac66743851e53578172a563ee1e96f7
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 92e913a5414ea3a7fb002a139251bb8ae53c467c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2022-11-28 14:49:03 +01:00 committed by Qt Cherry-pick Bot
parent 0f43a04de7
commit e4ccda5ba9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/auto/corelib/text/qstringapisymmetry/tst_qstringapisymmetry.cpp
View File

@ -227,8 +227,10 @@ private Q_SLOTS:
void compare_QStringView_QString() { compare_impl<QStringView, QString>(); } void compare_QStringView_QString() { compare_impl<QStringView, QString>(); }
void compare_QStringView_QStringView_data() { compare_data(); } void compare_QStringView_QStringView_data() { compare_data(); }
void compare_QStringView_QStringView() { compare_impl<QStringView, QStringView>(); } void compare_QStringView_QStringView() { compare_impl<QStringView, QStringView>(); }
#ifdef NOT_YET_IMPLEMENTED
void compare_QStringView_QUtf8StringView_data() { compare_data(); } void compare_QStringView_QUtf8StringView_data() { compare_data(); }
void compare_QStringView_QUtf8StringView() { compare_impl<QStringView, QStringView>(); } void compare_QStringView_QUtf8StringView() { compare_impl<QStringView, QUtf8StringView>(); }
#endif
void compare_QStringView_QLatin1String_data() { compare_data(); } void compare_QStringView_QLatin1String_data() { compare_data(); }
void compare_QStringView_QLatin1String() { compare_impl<QStringView, QLatin1String>(); } void compare_QStringView_QLatin1String() { compare_impl<QStringView, QLatin1String>(); }
#ifdef NOT_YET_IMPLMENTED #ifdef NOT_YET_IMPLMENTED