From e3b0d2f93cc839fa60f8a1c580933b5d9e654c64 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Mon, 17 Jun 2024 15:44:12 -0700 Subject: [PATCH] QLibrary/Unix: fix mojibake of dlerror() Amends a6a56814702612d8981f594a6158d70a7928cb99 where I replaced a function that correctly did QString::fromLocal8Bit() with QLatin1StringView. Pick-to: 6.7 Change-Id: Ic0adfa808d28487a8303fffd17d9ec0817eda3e8 Reviewed-by: Giuseppe D'Angelo (cherry picked from commit 0a1a8355f313ac951e3e615f47aca40f421fc4bc) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/plugin/qlibrary_unix.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/corelib/plugin/qlibrary_unix.cpp b/src/corelib/plugin/qlibrary_unix.cpp index a6fb5403cd5..2edd71487d5 100644 --- a/src/corelib/plugin/qlibrary_unix.cpp +++ b/src/corelib/plugin/qlibrary_unix.cpp @@ -236,8 +236,8 @@ bool QLibraryPrivate::load_sys() locker.relock(); if (!hnd) { - errorString = QLibrary::tr("Cannot load library %1: %2").arg(fileName, - QLatin1StringView(dlerror())); + errorString = QLibrary::tr("Cannot load library %1: %2") + .arg(fileName, QString::fromLocal8Bit(dlerror())); } if (hnd) { qualifiedFileName = attempt; @@ -262,8 +262,8 @@ bool QLibraryPrivate::unload_sys() if (!qstrcmp(error, "Shared objects still referenced")) // On QNX that's only "informative" return true; #endif - errorString = QLibrary::tr("Cannot unload library %1: %2").arg(fileName, - QLatin1StringView(error)); + errorString = QLibrary::tr("Cannot unload library %1: %2") + .arg(fileName, QString::fromLocal8Bit(error)); return false; } errorString.clear();