From e31c6c7337477fa708e09311667ed3a8ace1b6b0 Mon Sep 17 00:00:00 2001 From: Joerg Bornemann Date: Thu, 5 Nov 2020 12:20:35 +0100 Subject: [PATCH] CMake: Add version information to Qt plugin DLLs Tools and library DLLs already have version information embedded. Add the missing _qt_internal_generate_win32_rc_file call for plugins. Fixes: QTBUG-87747 Change-Id: I619948f4066ce229d41e8b93f125751e1d28e26c Reviewed-by: Cristian Adam Reviewed-by: Alexandru Croitor --- cmake/QtPluginHelpers.cmake | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cmake/QtPluginHelpers.cmake b/cmake/QtPluginHelpers.cmake index b29eb4ebf0a..b5250a47175 100644 --- a/cmake/QtPluginHelpers.cmake +++ b/cmake/QtPluginHelpers.cmake @@ -292,6 +292,10 @@ function(qt_internal_add_plugin target) endfunction() function(qt_finalize_plugin target install_directory) + if(WIN32 AND BUILD_SHARED_LIBS) + _qt_internal_generate_win32_rc_file("${target}") + endif() + # Generate .prl files for plugins of static Qt builds. if(NOT BUILD_SHARED_LIBS) qt_generate_prl_file(${target} "${install_directory}")