1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

a11y: Remove a ### Qt6 that doesn't make much sense

Browse Source 
Since the enum names are "the same", the comment seems to suggest to
change the enum value of Canvas to 0x401. I don't see any benefit to
that really.

In addition, we are today using UIA in favor of MSAA, and the closest
matching role (controlTypeId) seems to be for a static image
(UIA_ImageControlTypeId), which is quite different from the semantic of
IA2_ROLE_CANVAS.

For the record, here's a list of similar roles for different a11y APIs:

IA2:
  IA2_ROLE_CANVAS        An object that can be drawn into and to manage
			 events from the objects drawn into it. Also
			 refer to IA2_ROLE_FRAME, IA2_ROLE_GLASS_PANE,
			 and IA2_ROLE_LAYERED_PANE.

MSAA:
  ROLE_SYSTEM_DIAGRAM    The object represents a graphical image that is
                         used to diagram data.

UIA:
  UIA_ImageControlTypeId Identifies the _Image_ control type.

atspi:
  ATSPI_ROLE_CANVAS      Object that can be drawn into and is used to
                         trap events.

Change-Id: Ic2ead0dc40be0ae2e798f49285eb6a392cc29142
Reviewed-by: André de la Rocha <andre.rocha@qt.io>
This commit is contained in:
Jan Arve Sæther 2020-02-11 09:32:01 +01:00
parent 9a5df00a61
commit e290ebae9f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/gui/accessible/qaccessible.h
View File

@ -280,7 +280,7 @@ public:
HotkeyField = 0x00000032,
Slider = 0x00000033,
SpinBox = 0x00000034,
Canvas = 0x00000035, // Diagram for MSAA
Canvas = 0x00000035, // MSAA: ROLE_SYSTEM_DIAGRAM - The object represents a graphical image that is used to diagram data.
Animation = 0x00000036,
Equation = 0x00000037,
ButtonDropDown = 0x00000038, // The object represents a button that expands a grid.
@ -302,7 +302,7 @@ public:
Notification = 0x00000086,
// IAccessible2 roles
// IA2_ROLE_CANVAS = 0x401, ### Qt 6 use this one instead of Canvas above
// IA2_ROLE_CANVAS = 0x401, // An object that can be drawn into and to manage events from the objects drawn into it
// IA2_ROLE_CAPTION = 0x402,
// IA2_ROLE_CHECK_MENU_ITEM = 0x403,
ColorChooser = 0x404,