From e2198f7580a69c73015b8be08d07fab815a5740d Mon Sep 17 00:00:00 2001 From: Ivan Solovev Date: Mon, 2 Sep 2024 10:50:21 +0200 Subject: [PATCH] QNetworkReply::setWellKnownHeaders: use QByteArrayView MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The private implementation already uses QByteArrayView, so the fix is trivial. Amends c6438054b91b7017b95706677e0194ed4f1e9e7d. Found in 6.8 API review. Change-Id: I41a62557ca82d31a814ceb3f5079a60ca8c437c4 Reviewed-by: Mårten Nordheim Reviewed-by: Marc Mutz (cherry picked from commit 525bbfb5dfd1a5f3a6e4a5bc0126714232e20f9d) Reviewed-by: Qt Cherry-pick Bot --- src/network/access/qnetworkreply.cpp | 2 +- src/network/access/qnetworkreply.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/access/qnetworkreply.cpp b/src/network/access/qnetworkreply.cpp index 3301ae85d21..1076ba960c1 100644 --- a/src/network/access/qnetworkreply.cpp +++ b/src/network/access/qnetworkreply.cpp @@ -931,7 +931,7 @@ void QNetworkReply::setHeaders(QHttpHeaders &&newHeaders) Sets the header \a name to be of value \a value. If \a name was previously set, it is overridden. */ -void QNetworkReply::setWellKnownHeader(QHttpHeaders::WellKnownHeader name, const QByteArray &value) +void QNetworkReply::setWellKnownHeader(QHttpHeaders::WellKnownHeader name, QByteArrayView value) { Q_D(QNetworkReply); d->setHeader(name, value); diff --git a/src/network/access/qnetworkreply.h b/src/network/access/qnetworkreply.h index 48ec0397c69..a4498ac0fd4 100644 --- a/src/network/access/qnetworkreply.h +++ b/src/network/access/qnetworkreply.h @@ -155,7 +155,7 @@ protected: void setRawHeader(const QByteArray &headerName, const QByteArray &value); void setHeaders(const QHttpHeaders &newHeaders); void setHeaders(QHttpHeaders &&newHeaders); - void setWellKnownHeader(QHttpHeaders::WellKnownHeader name, const QByteArray &value); + void setWellKnownHeader(QHttpHeaders::WellKnownHeader name, QByteArrayView value); void setAttribute(QNetworkRequest::Attribute code, const QVariant &value); #if QT_CONFIG(ssl)