From e20ebd5a26d42185206577408238c83306de05a2 Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Wed, 7 Jun 2023 17:14:01 +0200 Subject: [PATCH] Stabilize QFile::unixPipe/socketPair tests We observe failures in CI on QNX because the measured timeout is ~995ms rather than the expected 1000ms. Start the timer before the thread starts to guarantee that at least as much time elapses as the thread waits before writing the second byte to the pipe. Otherwise, the thread might be sleeping already when the timer starts, and then we can't rely on any measurements. Change-Id: I6072569a987f5e952b0953e0e394a223f891fd25 Reviewed-by: Dimitrios Apostolou (cherry picked from commit 30e5ff3ff223d665fbed3baf2d08ad3fcf2b8455) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/corelib/io/qfile/tst_qfile.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/auto/corelib/io/qfile/tst_qfile.cpp b/tests/auto/corelib/io/qfile/tst_qfile.cpp index e5f4bd67927..64a3687e2a4 100644 --- a/tests/auto/corelib/io/qfile/tst_qfile.cpp +++ b/tests/auto/corelib/io/qfile/tst_qfile.cpp @@ -2635,6 +2635,9 @@ static void unixPipe_helper(int pipes[2]) c = 2; qt_safe_write(fd, &c, 1); })); + + QElapsedTimer timer; + timer.start(); thr->start(); // synchronize with the thread having started @@ -2643,8 +2646,6 @@ static void unixPipe_helper(int pipes[2]) QCOMPARE(c, '\1'); QFETCH(bool, useStdio); - QElapsedTimer timer; - timer.start(); QFile f; if (useStdio) { FILE *fh = fdopen(pipes[0], "rb"); @@ -2658,8 +2659,8 @@ static void unixPipe_helper(int pipes[2]) c = 0; QCOMPARE(f.read(&c, 1), 1); QCOMPARE(c, '\2'); - int elapsed = timer.elapsed(); - QVERIFY2(elapsed >= Timeout, QByteArray::number(elapsed)); + const int elapsed = timer.elapsed(); + QCOMPARE_GE(elapsed, Timeout); thr->wait(); }