From de699decb49929845aff1ade4cdf1074ea640ebf Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Mon, 14 Mar 2022 10:51:59 +0100 Subject: [PATCH] QFSFileEngine: don't call QFileSystemEntry::filePath() twice MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cache the result. Clean up the return statement as a drive-by. Change-Id: Ic1bebd4ad4dd970202701be60fbcd286b9924df5 Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Edward Welbourne Reviewed-by: Thiago Macieira --- src/corelib/io/qfsfileengine_unix.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/corelib/io/qfsfileengine_unix.cpp b/src/corelib/io/qfsfileengine_unix.cpp index d071c85cb35..9e4a72edf83 100644 --- a/src/corelib/io/qfsfileengine_unix.cpp +++ b/src/corelib/io/qfsfileengine_unix.cpp @@ -498,7 +498,8 @@ QString QFSFileEngine::fileName(FileName file) const bool QFSFileEngine::isRelativePath() const { Q_D(const QFSFileEngine); - return d->fileEntry.filePath().length() ? d->fileEntry.filePath().at(0) != QLatin1Char('/') : true; + const QString fp = d->fileEntry.filePath(); + return fp.isEmpty() || fp.at(0) != u'/'; } uint QFSFileEngine::ownerId(FileOwner own) const