1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QCocoaPrintDevice: fix bad CFRelease

Browse Source 
CFRelease should be called IFF PMPrinterCopyDescriptionURL succeeds

Change-Id: Id289aea3a4e3da397dae4062319256a043538597
Reviewed-by: Jake Petroules <jake.petroules@petroules.com>
This commit is contained in:
Dyami Caliri 2014-10-29 14:10:05 -07:00
parent af5f6e35b6
commit dd6876f3fd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/platforms/cocoa/qcocoaprintdevice.mm
View File

@ -468,11 +468,11 @@ bool QCocoaPrintDevice::openPpdFile()
CFURLRef ppdURL = NULL; CFURLRef ppdURL = NULL;
char ppdPath[MAXPATHLEN]; char ppdPath[MAXPATHLEN];
if (PMPrinterCopyDescriptionURL(m_printer, kPMPPDDescriptionType, &ppdURL) == noErr if (PMPrinterCopyDescriptionURL(m_printer, kPMPPDDescriptionType, &ppdURL) == noErr
&& ppdURL != NULL && ppdURL != NULL) {
&& CFURLGetFileSystemRepresentation(ppdURL, true, (UInt8*)ppdPath, sizeof(ppdPath))) { if (CFURLGetFileSystemRepresentation(ppdURL, true, (UInt8*)ppdPath, sizeof(ppdPath)))
m_ppd = ppdOpenFile(ppdPath); m_ppd = ppdOpenFile(ppdPath);
CFRelease(ppdURL);
} }
CFRelease(ppdURL);
return m_ppd ? true : false; return m_ppd ? true : false;
} }