1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove flaky and duplicate animateClick tests

Browse Source 
The animateClick method is a QAbstractButton member, and neither
QCommandLinkButton nor QPushButton override it. The method is tested in
the QAbstractButton test, and 3a9b7d1f18648d7236664d3adfc65c009b01e668
made that test more robust. The previous, flaky version of the test was
almost duplicated here. They add no additional code coverage, so remove
them.

Pick-to: 6.2 6.3
Change-Id: I1fa988c1eabd5054193acb1f5fa1c81d29b3878d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
This commit is contained in:
Volker Hilsheimer 2022-01-21 09:42:40 +01:00
parent e502906305
commit dd3ea45c23
2 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tests/auto/widgets/widgets/qcommandlinkbutton/tst_qcommandlinkbutton.cpp
View File

@ -58,7 +58,6 @@ private slots:
void setDown();
void popupCrash();
void isChecked();
void animateClick();
void toggle();
void clicked();
void toggled();
@ -363,20 +362,6 @@ void tst_QCommandLinkButton::setAccel()
#endif // QT_CONFIG(shortcut)
void tst_QCommandLinkButton::animateClick()
{
QVERIFY( !testWidget->isDown() );
testWidget->animateClick();
QVERIFY( testWidget->isDown() );
QTest::qWait( 200 );
QVERIFY( !testWidget->isDown() );
QVERIFY( click_count == 1 );
QVERIFY( press_count == 1 );
QVERIFY( release_count == 1 );
QVERIFY( toggle_count == 0 );
}
void tst_QCommandLinkButton::clicked()
{
QTest::mousePress( testWidget, Qt::LeftButton );

15
tests/auto/widgets/widgets/qpushbutton/tst_qpushbutton.cpp
View File

@ -60,7 +60,6 @@ private slots:
void setDown();
void popupCrash();
void isChecked();
void animateClick();
void toggle();
void clicked();
void touchTap();
@ -361,20 +360,6 @@ void tst_QPushButton::setAccel()
#endif // QT_CONFIG(shortcut)
void tst_QPushButton::animateClick()
{
QVERIFY( !testWidget->isDown() );
testWidget->animateClick();
QVERIFY( testWidget->isDown() );
QTest::qWait( 200 );
QVERIFY( !testWidget->isDown() );
QVERIFY( click_count == 1 );
QVERIFY( press_count == 1 );
QVERIFY( release_count == 1 );
QVERIFY( toggle_count == 0 );
}
void tst_QPushButton::clicked()
{
QTest::mousePress( testWidget, Qt::LeftButton );