1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Rework the start-of-time fileTimes() test to add another test-case

Browse Source 
Turned it into a data-driven test, with the old start-of-time as one
row, in order to add a regression test for an alleged MS API bug in
Windows XP.

Task-number: QTBUG-12006
Change-Id: I632ecc854f50f4183a990c8a27826ede9bd20e55
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Edward Welbourne 2018-07-23 18:54:20 +02:00
parent 09f254fcc0
commit dcd35d13e0
1 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/auto/corelib/io/qfileinfo/tst_qfileinfo.cpp
View File

@ -199,7 +199,8 @@ private slots:
void fileTimes_data(); void fileTimes_data();
void fileTimes(); void fileTimes();
void fileTimes_oldFile(); void fakeFileTimes_data();
void fakeFileTimes();
void isSymLink_data(); void isSymLink_data();
void isSymLink(); void isSymLink();
@ -1212,12 +1213,23 @@ void tst_QFileInfo::fileTimes()
QVERIFY(writeTime < beforeRead); QVERIFY(writeTime < beforeRead);
} }
void tst_QFileInfo::fileTimes_oldFile() void tst_QFileInfo::fakeFileTimes_data()
{ {
QTest::addColumn<QDateTime>("when");
// This is 2^{31} seconds before 1970-01-01 15:14:8, // This is 2^{31} seconds before 1970-01-01 15:14:8,
// i.e. shortly after the start of time_t, in any time-zone: // i.e. shortly after the start of time_t, in any time-zone:
const QDateTime early(QDate(1901, 12, 14), QTime(12, 0)); QTest::newRow("early") << QDateTime(QDate(1901, 12, 14), QTime(12, 0));
QFile file("ancientfile.txt");
// QTBUG-12006 claims XP handled this (2010-Mar-26 8:46:10) wrong due to an MS API bug:
QTest::newRow("XP-bug") << QDateTime::fromTime_t(1269593170);
}
void tst_QFileInfo::fakeFileTimes()
{
QFETCH(QDateTime, when);
QFile file("faketimefile.txt");
file.open(QIODevice::WriteOnly); file.open(QIODevice::WriteOnly);
file.write("\n", 1); file.write("\n", 1);
file.close(); file.close();
@ -1228,15 +1240,13 @@ void tst_QFileInfo::fileTimes_oldFile()
modification time, so need to re-open for read in order to setFileTime(). modification time, so need to re-open for read in order to setFileTime().
*/ */
file.open(QIODevice::ReadOnly); file.open(QIODevice::ReadOnly);
bool ok = file.setFileTime(early, QFileDevice::FileModificationTime); bool ok = file.setFileTime(when, QFileDevice::FileModificationTime);
file.close(); file.close();
if (ok) { if (ok)
QFileInfo info(file.fileName()); QCOMPARE(QFileInfo(file.fileName()).lastModified(), when);
QCOMPARE(info.lastModified(), early); else
} else { QSKIP("Unable to set file metadata to contrived values");
QSKIP("Unable to set file metadata to ancient values");
}
} }
void tst_QFileInfo::isSymLink_data() void tst_QFileInfo::isSymLink_data()