1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Member initialization and default constructor for QProgressDialogPrivate

Browse Source 
Change QProgressDialogPrivate to use default member initializers,
allowing its constructor to be explicitly defaulted since it was only
used for its member initializer list. Reduces #ifdefery.

Change-Id: Id3885e6d520cde47de96f3b475f6a6bba1ed001f
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
This commit is contained in:
Christian Heimlich 2020-10-07 04:07:36 -04:00
parent 0efe79f80d
commit dc19327751
1 changed files with 15 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/widgets/dialogs/qprogressdialog.cpp
View File

@ -68,21 +68,7 @@ class QProgressDialogPrivate : public QDialogPrivate
Q_DECLARE_PUBLIC(QProgressDialog)
public:
QProgressDialogPrivate() : label(nullptr), cancel(nullptr), bar(nullptr),
#ifndef QT_NO_SHORTCUT
escapeShortcut(nullptr),
#endif
showTime(defaultShowTime),
processingEvents(false),
shownOnce(false),
autoClose(true),
autoReset(true),
forceHide(false),
cancellationFlag(false),
setValueCalled(false),
useDefaultCancelText(false)
{
}
QProgressDialogPrivate() = default;
void init(const QString &labelText, const QString &cancelText, int min, int max);
void layout();
@ -92,25 +78,25 @@ public:
void ensureSizeIsAtLeastSizeHint();
void _q_disconnectOnClose();
QLabel *label;
QPushButton *cancel;
QProgressBar *bar;
QTimer *forceTimer;
QLabel *label = nullptr;
QPushButton *cancel = nullptr;
QProgressBar *bar = nullptr;
QTimer *forceTimer = nullptr;
#ifndef QT_NO_SHORTCUT
QShortcut *escapeShortcut;
QShortcut *escapeShortcut = nullptr;
#endif
QPointer<QObject> receiverToDisconnectOnClose;
QElapsedTimer starttime;
QByteArray memberToDisconnectOnClose;
int showTime;
bool processingEvents;
bool shownOnce;
bool autoClose;
bool autoReset;
bool forceHide;
bool cancellationFlag;
bool setValueCalled;
bool useDefaultCancelText;
int showTime = defaultShowTime;
bool processingEvents = false;
bool shownOnce = false;
bool autoClose = true;
bool autoReset = true;
bool forceHide = false;
bool cancellationFlag = false;
bool setValueCalled = false;
bool useDefaultCancelText = false;
};
void QProgressDialogPrivate::init(const QString &labelText, const QString &cancelText,