diff --git a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp index ed413107c0c..12531c9176a 100644 --- a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp +++ b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp @@ -960,80 +960,72 @@ Q_DECLARE_METATYPE(QPairPP) enum FlagsDataEnum {}; Q_DECLARE_METATYPE(FlagsDataEnum); +template void addFlagsRow(const char *name, int id = qMetaTypeId()) +{ + QTest::newRow(name) + << id + << bool(QTypeInfo::isRelocatable) + << bool(QTypeInfo::isComplex) + << bool(QtPrivate::IsPointerToTypeDerivedFromQObject::Value) + << bool(std::is_enum::value) + << false; +} + void tst_QMetaType::flags_data() { QTest::addColumn("type"); - QTest::addColumn("isMovable"); + QTest::addColumn("isRelocatable"); QTest::addColumn("isComplex"); QTest::addColumn("isPointerToQObject"); QTest::addColumn("isEnum"); QTest::addColumn("isQmlList"); -#define ADD_METATYPE_TEST_ROW(MetaTypeName, MetaTypeId, RealType) \ - QTest::newRow(#RealType) << MetaTypeId \ - << bool(QTypeInfo::isRelocatable) \ - << bool(QTypeInfo::isComplex) \ - << bool(QtPrivate::IsPointerToTypeDerivedFromQObject::Value) \ - << bool(std::is_enum::value) \ - << false; -QT_FOR_EACH_STATIC_CORE_CLASS(ADD_METATYPE_TEST_ROW) -QT_FOR_EACH_STATIC_PRIMITIVE_POINTER(ADD_METATYPE_TEST_ROW) -QT_FOR_EACH_STATIC_CORE_POINTER(ADD_METATYPE_TEST_ROW) -#undef ADD_METATYPE_TEST_ROW - QTest::newRow("TestSpace::Foo") << ::qMetaTypeId() << false << true << false << false << false; - QTest::newRow("Whity") << ::qMetaTypeId >() << true << true << false << false << false; - QTest::newRow("CustomMovable") << ::qMetaTypeId() << true << true << false << false << false; - QTest::newRow("CustomObject*") << ::qMetaTypeId() << true << false << true << false << false; - QTest::newRow("CustomMultiInheritanceObject*") << ::qMetaTypeId() << true << false << true << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << false << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << true << false << false << false; - QTest::newRow("QPair") << ::qMetaTypeId >() << true << false << false << false << false; - QTest::newRow("FlagsDataEnum") << ::qMetaTypeId() << true << false << false << true << false; - // invalid ids. QTest::newRow("-1") << -1 << false << false << false << false << false; QTest::newRow("-124125534") << -124125534 << false << false << false << false << false; QTest::newRow("124125534") << 124125534 << false << false << false << false << false; + +#define ADD_METATYPE_TEST_ROW(MetaTypeName, MetaTypeId, RealType) \ + addFlagsRow(#RealType, MetaTypeId); +QT_FOR_EACH_STATIC_PRIMITIVE_NON_VOID_TYPE(ADD_METATYPE_TEST_ROW) +QT_FOR_EACH_STATIC_CORE_CLASS(ADD_METATYPE_TEST_ROW) +QT_FOR_EACH_STATIC_PRIMITIVE_POINTER(ADD_METATYPE_TEST_ROW) +QT_FOR_EACH_STATIC_CORE_POINTER(ADD_METATYPE_TEST_ROW) +#undef ADD_METATYPE_TEST_ROW + addFlagsRow("TestSpace::Foo"); + addFlagsRow >("Whity "); + addFlagsRow("CustomMovable"); + addFlagsRow("CustomObject*"); + addFlagsRow("CustomMultiInheritanceObject*"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow >("QPair"); + addFlagsRow("FlagsDataEnum"); } void tst_QMetaType::flags() { QFETCH(int, type); - QFETCH(bool, isMovable); + QFETCH(bool, isRelocatable); QFETCH(bool, isComplex); QFETCH(bool, isPointerToQObject); QFETCH(bool, isEnum); QFETCH(bool, isQmlList); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::NeedsConstruction), isComplex); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::NeedsDestruction), isComplex); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::RelocatableType), isMovable); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::PointerToQObject), isPointerToQObject); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::IsEnumeration), isEnum); - QCOMPARE(bool(QMetaType::typeFlags(type) & QMetaType::IsQmlList), isQmlList); -} + QMetaType meta(type); -void tst_QMetaType::flagsStaticLess_data() -{ - flags_data(); -} - -void tst_QMetaType::flagsStaticLess() -{ - QFETCH(int, type); - QFETCH(bool, isMovable); - QFETCH(bool, isComplex); - - int flags = QMetaType(type).flags(); - QCOMPARE(bool(flags & QMetaType::NeedsConstruction), isComplex); - QCOMPARE(bool(flags & QMetaType::NeedsDestruction), isComplex); - QCOMPARE(bool(flags & QMetaType::RelocatableType), isMovable); + QCOMPARE(bool(meta.flags() & QMetaType::NeedsConstruction), isComplex); + QCOMPARE(bool(meta.flags() & QMetaType::NeedsDestruction), isComplex); + QCOMPARE(bool(meta.flags() & QMetaType::RelocatableType), isRelocatable); + QCOMPARE(bool(meta.flags() & QMetaType::PointerToQObject), isPointerToQObject); + QCOMPARE(bool(meta.flags() & QMetaType::IsEnumeration), isEnum); + QCOMPARE(bool(meta.flags() & QMetaType::IsQmlList), isQmlList); } void tst_QMetaType::flagsBinaryCompatibility6_0_data() diff --git a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.h b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.h index 588e52c4f6b..a30963a919e 100644 --- a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.h +++ b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.h @@ -69,8 +69,6 @@ private slots: void alignOf(); void flags_data(); void flags(); - void flagsStaticLess_data(); - void flagsStaticLess(); void flagsBinaryCompatibility6_0_data(); void flagsBinaryCompatibility6_0(); void construct_data(); diff --git a/tests/auto/gui/kernel/qguimetatype/tst_qguimetatype.cpp b/tests/auto/gui/kernel/qguimetatype/tst_qguimetatype.cpp index ff464e29c9c..f4d64567ecd 100644 --- a/tests/auto/gui/kernel/qguimetatype/tst_qguimetatype.cpp +++ b/tests/auto/gui/kernel/qguimetatype/tst_qguimetatype.cpp @@ -293,6 +293,15 @@ struct TypeAlignment enum { Value = alignof(T) }; }; +template void addFlagsRow(const char *name, int id = qMetaTypeId()) +{ + QTest::newRow(name) + << id + << bool(QTypeInfo::isRelocatable) + << bool(QTypeInfo::isComplex); +} + + void tst_QGuiMetaType::flags_data() { QTest::addColumn("type"); @@ -300,7 +309,7 @@ void tst_QGuiMetaType::flags_data() QTest::addColumn("isComplex"); #define ADD_METATYPE_TEST_ROW(MetaTypeName, MetaTypeId, RealType) \ - QTest::newRow(#RealType) << MetaTypeId << bool(QTypeInfo::isRelocatable) << bool(QTypeInfo::isComplex); + addFlagsRow(#RealType, MetaTypeId); QT_FOR_EACH_STATIC_GUI_CLASS(ADD_METATYPE_TEST_ROW) #undef ADD_METATYPE_TEST_ROW }