1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Schannel: fix handling of empty ciphers list

Browse Source 
Contrary to OpenSSL the new ciphers support in Schannel
would disallow all ciphers when the list was empty.
The pre-existing behavior was to use the default list.

Amends f7792d2b6d3d1e5dd47a8f6429b817b793bcfb9b

Change-Id: I0e79013ac86261c4afa4affb28cb1838177c12de
Reviewed-by: Tobias Koenig <tobias.koenig@kdab.com>
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
(cherry picked from commit 2d521002ca024b71525036a0a6f5d02bb09b3ed7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 58991ca2ae2b92a96760fb781360caebc6c6fdc8)
This commit is contained in:
Mårten Nordheim 2024-03-11 16:58:24 +01:00
parent b45d7cc24c
commit d86a93ba21
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/tls/schannel/qtls_schannel.cpp
View File

@ -1145,10 +1145,12 @@ bool TlsCryptographSchannel::acquireCredentialsHandle()
}
const QList<QSslCipher> ciphers = configuration.ciphers();
if (!containsTls13Cipher(ciphers))
if (!ciphers.isEmpty() && !containsTls13Cipher(ciphers))
protocols &= ~SP_PROT_TLS1_3;
QList<CRYPTO_SETTINGS> cryptoSettings = cryptoSettingsForCiphers(ciphers);
QList<CRYPTO_SETTINGS> cryptoSettings;
if (!ciphers.isEmpty())
cryptoSettings = cryptoSettingsForCiphers(ciphers);
TLS_PARAMETERS tlsParameters = {
0,