From d7d144b530150c2730bab3c0835b490fe53e57f8 Mon Sep 17 00:00:00 2001 From: Amir Masoud Abdol Date: Mon, 23 Oct 2023 08:00:56 +0000 Subject: [PATCH] Revert "Make sure that pkgconf can find HarfBuzz" This reverts commit 885d87488ade83b37519a3b08cd968dc76a661c2. Reason for revert: Issue was caused by a faulty `.pc` file which was reported to upstream, in addition, the patch might not be effective in certain cases as tested by the reporter. See the bug report for further information. Change-Id: I2b75a79f47b77a660bd23cd41df40df9ea4baef2 Reviewed-by: Alexey Edelev --- cmake/FindWrapSystemHarfbuzz.cmake | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cmake/FindWrapSystemHarfbuzz.cmake b/cmake/FindWrapSystemHarfbuzz.cmake index 9651c56a95b..07b3405bc07 100644 --- a/cmake/FindWrapSystemHarfbuzz.cmake +++ b/cmake/FindWrapSystemHarfbuzz.cmake @@ -32,12 +32,8 @@ endif() if(__harfbuzz_broken_config_file OR NOT __harfbuzz_found) find_package(PkgConfig QUIET) - if(PKG_CONFIG_EXECUTABLE MATCHES "pkgconf") - # pkgconf is an alternative implementation of pkg-config - set(pkgconf_is_used TRUE) - endif() pkg_check_modules(PC_HARFBUZZ IMPORTED_TARGET "harfbuzz") - if(PC_HARFBUZZ_FOUND AND NOT pkgconf_is_used) + if(PC_HARFBUZZ_FOUND) set(__harfbuzz_target_name "PkgConfig::PC_HARFBUZZ") set(__harfbuzz_find_include_dirs_hints HINTS ${PC_HARFBUZZ_INCLUDEDIR}) @@ -59,7 +55,7 @@ if(__harfbuzz_broken_config_file OR NOT __harfbuzz_found) if(HARFBUZZ_INCLUDE_DIRS AND HARFBUZZ_LIBRARIES) set(__harfbuzz_found TRUE) - if(NOT PC_HARFBUZZ_FOUND OR pkgconf_is_used) + if(NOT PC_HARFBUZZ_FOUND) add_library(${__harfbuzz_target_name} UNKNOWN IMPORTED) list(TRANSFORM HARFBUZZ_INCLUDE_DIRS APPEND "/harfbuzz") set_target_properties(${__harfbuzz_target_name} PROPERTIES