1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix some compiler warnings from tests

Browse Source 
For iterators that return a value, don't use reference in ranged for,
and cast numeric literal to correct size type for QCOMPARE.

Change-Id: Idfd09dbc2ef3ab1bf025c7859ea6e2e9572bc9a1
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
This commit is contained in:
Volker Hilsheimer 2020-10-16 10:44:59 +02:00
parent c6b3680bcf
commit d72ff6ffd0
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/corelib/serialization/qcborvalue/tst_qcborvalue.cpp
View File

@ -790,7 +790,7 @@ void tst_QCborValue::arrayInitializerList()
// range for
int i = 0;
for (const QCborValue &v : qAsConst(a)) {
for (const QCborValue v : qAsConst(a)) {
QVERIFY(!v.isInvalid());
QCOMPARE(v.isUndefined(), i == 5); // 6th element is Undefined
++i;

4
tests/auto/corelib/text/qstringview/tst_qstringview.cpp
View File

@ -426,9 +426,9 @@ void tst_QStringView::literals() const
}
// these are different results
QCOMPARE(size_t(QStringView(withnull).size()), 1);
QCOMPARE(size_t(QStringView(withnull).size()), size_t(1));
QCOMPARE(size_t(QStringView::fromArray(withnull).size()), sizeof(withnull)/sizeof(withnull[0]));
QCOMPARE(QStringView(withnull + 0).size(), 1);
QCOMPARE(QStringView(withnull + 0).size(), qsizetype(1));
}
void tst_QStringView::fromArray() const