1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QStorageInfo: actually make the (in)equality operators noexcept

Browse Source 
Do not use the getters, as they are not noexcept. Directly access
the members of the d_ptr instead.

Amends d292648d0bbac50388dae035dc34782accb3807f.

Found in 6.8 API review.

Change-Id: I69eee9db2274d1e99a4f56e841cfaea223341ced
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 495a06a22aef2aa62dd993217e4f4ec099ad4e94)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Ivan Solovev 2024-08-27 11:35:34 +02:00 committed by Qt Cherry-pick Bot
parent 9f06e0b1f8
commit d6e8fa64e8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/io/qstorageinfo.cpp
View File

@ -408,7 +408,7 @@ bool comparesEqual(const QStorageInfo &lhs, const QStorageInfo &rhs) noexcept
{
if (lhs.d == rhs.d)
return true;
return lhs.device() == rhs.device() && lhs.rootPath() == rhs.rootPath();
return lhs.d->device == rhs.d->device && lhs.d->rootPath == rhs.d->rootPath;
}
#ifndef QT_NO_DEBUG_STREAM