From d520bfe803141455234eb8200a821bab750b51d1 Mon Sep 17 00:00:00 2001
From: Mate Barany <mate.barany@qt.io>
Date: Mon, 22 Jul 2024 14:12:30 +0200
Subject: [PATCH] Initialize error in QSslErrorPrivate
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Axivion warning: "Compiler-generated constructor leaves some fields
uninitialized."

As the constructor of QSslError sets the error to QSslError::NoError
do the same in QSslErrorPrivate with NSDMI.

Task-number: QTBUG-125026
Pick-to: 6.7 6.5
Change-Id: I0db85dffb5eda3a6c768e326f87a01f8c176e4f1
Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit bc34fe0e351d682584387dbfe5adee06ff59895c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/network/ssl/qsslerror.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/network/ssl/qsslerror.cpp b/src/network/ssl/qsslerror.cpp
index 241e6291ac3..97faa8993c9 100644
--- a/src/network/ssl/qsslerror.cpp
+++ b/src/network/ssl/qsslerror.cpp
@@ -88,7 +88,7 @@ static_assert(sizeof(QScopedPointer<QSslErrorPrivate>) == sizeof(std::unique_ptr
 class QSslErrorPrivate
 {
 public:
-    QSslError::SslError error;
+    QSslError::SslError error = QSslError::NoError;
     QSslCertificate certificate;
 };
 
@@ -102,8 +102,6 @@ public:
 QSslError::QSslError()
     : d(new QSslErrorPrivate)
 {
-    d->error = QSslError::NoError;
-    d->certificate = QSslCertificate();
 }
 
 /*!
@@ -115,7 +113,6 @@ QSslError::QSslError(SslError error)
     : d(new QSslErrorPrivate)
 {
     d->error = error;
-    d->certificate = QSslCertificate();
 }
 
 /*!