From d4e0f8ee116cec32bd38b86835c4bd7e710f32ee Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 6 Mar 2025 13:39:31 +0100 Subject: [PATCH] QUrl: add a missing std::move() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The deslashified QString can be moved into place here. Found by Coverity. Amends 5e936b60fc921e21b8153a83113886a1de333b57. Pick-to: 6.8 Coverity-Id: 477475 Change-Id: Ibdaae0a9acae56960e16d5a6fd77fc1e08036af0 Reviewed-by: Thiago Macieira Reviewed-by: Øystein Heskestad Reviewed-by: Friedemann Kleint (cherry picked from commit 692f1a38a405b8bbef961b64d2577b4fbb2a03f9) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/io/qurl.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/corelib/io/qurl.cpp b/src/corelib/io/qurl.cpp index a7620e755f5..4b6eaf2079a 100644 --- a/src/corelib/io/qurl.cpp +++ b/src/corelib/io/qurl.cpp @@ -3390,7 +3390,7 @@ QUrl QUrl::fromLocalFile(const QString &localFile) // not directly using setPath here, as we do a few more transforms parseDecodedComponent(deslashified); if (!qt_urlRecode(url.d->path, deslashified, {}, localPathFromUser)) - url.d->path = deslashified; + url.d->path = std::move(deslashified); return url; }