From d24b0c05a495c53bcbf760e04b29b9b4310b8c7a Mon Sep 17 00:00:00 2001
From: Thiago Macieira <thiago.macieira@intel.com>
Date: Thu, 18 Apr 2024 08:12:33 -0700
Subject: [PATCH] QProcess: fix startCommand() with whitespace-only strings

We'd end up trying to takeFirst() from an empty QStringList.

[ChangeLog][QtCore][QProcess] Fixed a bug that would cause
startCommand() to crash if passed a string that was empty or contained
only whitespace characters.

Fixes: QTBUG-124512
Pick-to: 6.6 6.5
Change-Id: I455fe22ef4ad4b2f9b01fffd17c7689095c39272
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 60bdf2b220151021e59baa372a050b9f72400b81)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/corelib/io/qprocess.cpp                   |  4 ++++
 .../auto/corelib/io/qprocess/tst_qprocess.cpp | 20 +++++++++++++++++++
 2 files changed, 24 insertions(+)

diff --git a/src/corelib/io/qprocess.cpp b/src/corelib/io/qprocess.cpp
index 59b8b79e05c..b854c0749e7 100644
--- a/src/corelib/io/qprocess.cpp
+++ b/src/corelib/io/qprocess.cpp
@@ -2277,6 +2277,10 @@ void QProcess::start(OpenMode mode)
 void QProcess::startCommand(const QString &command, OpenMode mode)
 {
     QStringList args = splitCommand(command);
+    if (args.isEmpty()) {
+        qWarning("QProcess::startCommand: empty or whitespace-only command was provided");
+        return;
+    }
     const QString program = args.takeFirst();
     start(program, args, mode);
 }
diff --git a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
index 1056eaa107b..5f357329798 100644
--- a/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
+++ b/tests/auto/corelib/io/qprocess/tst_qprocess.cpp
@@ -48,6 +48,7 @@ private slots:
     void constructing();
     void simpleStart();
     void startCommand();
+    void startCommandEmptyString();
     void startWithOpen();
     void startWithOldOpen();
     void execute();
@@ -299,6 +300,25 @@ void tst_QProcess::startCommand()
     QCOMPARE(actual, expected);
 }
 
+void tst_QProcess::startCommandEmptyString()
+{
+    static const char warningMsg[] =
+            "QProcess::startCommand: empty or whitespace-only command was provided";
+    QProcess process;
+
+    QTest::ignoreMessage(QtWarningMsg, warningMsg);
+    process.startCommand("");
+    QVERIFY(!process.waitForStarted());
+
+    QTest::ignoreMessage(QtWarningMsg, warningMsg);
+    process.startCommand("   ");
+    QVERIFY(!process.waitForStarted());
+
+    QTest::ignoreMessage(QtWarningMsg, warningMsg);
+    process.startCommand("\t\n");
+    QVERIFY(!process.waitForStarted());
+}
+
 void tst_QProcess::startWithOpen()
 {
     QProcess p;