1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dialogs: use const methods more

Browse Source 
to avoid implicit detach

Change-Id: I2d46696a29f2a454452239e0400af2e2de534cbb
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Anton Kudryavtsev 2023-09-07 17:49:02 +03:00
parent 9a198e23d9
commit d232acbce0
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/widgets/dialogs/qfiledialog.cpp
View File

@ -1631,7 +1631,7 @@ QString QFileDialog::selectedMimeTypeFilter() const
for (const auto &mimeType: mimeTypes) { for (const auto &mimeType: mimeTypes) {
QString filter = nameFilterForMime(mimeType); QString filter = nameFilterForMime(mimeType);
if (testOption(HideNameFilterDetails)) if (testOption(HideNameFilterDetails))
filter = qt_strip_filters({ filter }).first(); filter = qt_strip_filters({ filter }).constFirst();
if (filter == nameFilter) { if (filter == nameFilter) {
mimeTypeFilter = mimeType; mimeTypeFilter = mimeType;
break; break;

2
src/widgets/dialogs/qfontdialog.cpp
View File

@ -502,7 +502,7 @@ void QFontDialogPrivate::updateFamilies()
match_t type = MATCH_NONE; match_t type = MATCH_NONE;
if (bestFamilyType <= MATCH_NONE && familyName2 == QStringLiteral("helvetica")) if (bestFamilyType <= MATCH_NONE && familyName2 == QStringLiteral("helvetica"))
type = MATCH_LAST_RESORT; type = MATCH_LAST_RESORT;
if (bestFamilyType <= MATCH_LAST_RESORT && familyName2 == f.families().first()) if (bestFamilyType <= MATCH_LAST_RESORT && familyName2 == f.families().constFirst())
type = MATCH_APP; type = MATCH_APP;
// ### add fallback for writingSystem // ### add fallback for writingSystem
if (type != MATCH_NONE) { if (type != MATCH_NONE) {