1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove QObjectPrivate::isSender/senderList, no longer used

Browse Source 
Only QAccessibleWidget was using them, and this was changed some time
ago. No point in keeping dead code.

Change-Id: I14bc40e6d87df234987e82385ce13433c2b82744
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
This commit is contained in:
David Faure 2024-03-12 14:45:57 +01:00
parent a88b6bca21
commit d1aa7b3d19
2 changed files with 0 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/corelib/kernel/qobject.cpp
View File

@ -226,27 +226,6 @@ static void computeOffsets(const QMetaObject *metaobject, int *signalOffset, int
}
}
// Used by QAccessibleWidget
bool QObjectPrivate::isSender(const QObject *receiver, const char *signal) const
{
Q_Q(const QObject);
int signal_index = signalIndex(signal);
ConnectionData *cd = connections.loadRelaxed();
if (signal_index < 0 || !cd)
return false;
QMutexLocker locker(signalSlotLock(q));
if (signal_index < cd->signalVectorCount()) {
const QObjectPrivate::Connection *c = cd->signalVector.loadRelaxed()->at(signal_index).first.loadRelaxed();
while (c) {
if (c->receiver.loadRelaxed() == receiver)
return true;
c = c->nextConnectionList.loadRelaxed();
}
}
return false;
}
// Used by QAccessibleWidget
QObjectList QObjectPrivate::receiverList(const char *signal) const
{
@ -268,19 +247,6 @@ QObjectList QObjectPrivate::receiverList(const char *signal) const
return returnValue;
}
// Used by QAccessibleWidget
QObjectList QObjectPrivate::senderList() const
{
QObjectList returnValue;
ConnectionData *cd = connections.loadRelaxed();
if (cd) {
QMutexLocker locker(signalSlotLock(q_func()));
for (Connection *c = cd->senders; c; c = c->next)
returnValue << c->sender;
}
return returnValue;
}
inline void QObjectPrivate::ensureConnectionData()
{
if (connections.loadRelaxed())

2
src/corelib/kernel/qobject_p.h
View File

@ -141,9 +141,7 @@ public:
void moveToThread_helper();
void setThreadData_helper(QThreadData *currentData, QThreadData *targetData, QBindingStatus *status);
bool isSender(const QObject *receiver, const char *signal) const;
QObjectList receiverList(const char *signal) const;
QObjectList senderList() const;
inline void ensureConnectionData();
inline void addConnection(int signal, Connection *c);