1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QThreadPool: use swap() when making a copy of allThreads

Browse Source 
This is the C++98 version of std::move().

Change-Id: Icb73da16bb05bf07114a38e4fd48732b612e2d51
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
This commit is contained in:
Marc Mutz 2012-08-17 10:55:38 +02:00 committed by Qt by Nokia
parent e2e1a08140
commit d0ae7bef48
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/corelib/thread/qthreadpool.cpp
View File

@ -269,9 +269,9 @@ void QThreadPoolPrivate::reset()
runnableReady.wakeAll(); runnableReady.wakeAll();
while (!allThreads.empty()) { while (!allThreads.empty()) {
// make a copy of the set so that we can iterate without the lock // move the contents of the set out so that we can iterate without the lock
QSet<QThreadPoolThread *> allThreadsCopy = allThreads; QSet<QThreadPoolThread *> allThreadsCopy;
allThreads.clear(); allThreadsCopy.swap(allThreads);
locker.unlock(); locker.unlock();
foreach (QThreadPoolThread *thread, allThreadsCopy) { foreach (QThreadPoolThread *thread, allThreadsCopy) {