1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QFileInfo: generalize old-file test

Browse Source 
Now that QFileDevice::setFileTime() provides a portable way to prepare
our test file, we can verify QFileInfo does handle the distant past,
notably including negative time_t values.  The old MS-specific code
used a time back in 1601, which we can't hope to support
cross-platform, so use one in 1901 that's a little inside the range of
32-bit time_t.

Task-number: QTBUG-47985
Change-Id: I2de3e79d8c7864221f92395813b63f373e4d8a3b
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Edward Welbourne 2016-08-25 14:52:05 +02:00
parent 3a9e135d55
commit cf9187f8c9
1 changed files with 21 additions and 47 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
tests/auto/corelib/io/qfileinfo/tst_qfileinfo.cpp
View File

@ -1204,55 +1204,29 @@ void tst_QFileInfo::fileTimes()
void tst_QFileInfo::fileTimes_oldFile() void tst_QFileInfo::fileTimes_oldFile()
{ {
// This is not supported on WinRT // This is 2^{31} seconds before 1970-01-01 15:14:8,
#if defined(Q_OS_WIN) && !defined(Q_OS_WINRT) // i.e. shortly after the start of time_t, in any time-zone:
// All files are opened in share mode (both read and write). const QDateTime early(QDate(1901, 12, 14), QTime(12, 0));
DWORD shareMode = FILE_SHARE_READ | FILE_SHARE_WRITE; QFile file("ancientfile.txt");
file.open(QIODevice::WriteOnly);
file.write("\n", 1);
file.close();
// All files on Windows can be read; there's no such thing as an /*
// unreadable file. Add GENERIC_WRITE if WriteOnly is passed. QFile's setFileTime calls QFSFileEngine::setFileTime() which fails unless
int accessRights = GENERIC_READ | GENERIC_WRITE; the file is open at the time. Of course, when writing, close() changes
modification time, so need to re-open for read in order to setFileTime().
*/
file.open(QIODevice::ReadOnly);
bool ok = file.setFileTime(early, QFileDevice::FileModificationTime);
file.close();
SECURITY_ATTRIBUTES securityAtts = { sizeof(SECURITY_ATTRIBUTES), NULL, TRUE }; if (ok) {
QFileInfo info(file.fileName());
// Regular file mode. In Unbuffered mode, pass the no-buffering flag. QCOMPARE(info.lastModified(), early);
DWORD flagsAndAtts = FILE_ATTRIBUTE_NORMAL; } else {
QSKIP("Unable to set file metadata to ancient values");
// WriteOnly can create files, ReadOnly cannot. }
DWORD creationDisp = OPEN_ALWAYS;
// Create the file handle.
HANDLE fileHandle = CreateFile(L"oldfile.txt",
accessRights,
shareMode,
&securityAtts,
creationDisp,
flagsAndAtts,
NULL);
// Set file times back to 1601.
SYSTEMTIME stime;
stime.wYear = 1601;
stime.wMonth = 1;
stime.wDayOfWeek = 1;
stime.wDay = 1;
stime.wHour = 1;
stime.wMinute = 0;
stime.wSecond = 0;
stime.wMilliseconds = 0;
FILETIME ctime;
QVERIFY(SystemTimeToFileTime(&stime, &ctime));
FILETIME atime = ctime;
FILETIME mtime = atime;
QVERIFY(fileHandle);
QVERIFY(SetFileTime(fileHandle, &ctime, &atime, &mtime) != 0);
CloseHandle(fileHandle);
QFileInfo info("oldfile.txt");
QCOMPARE(info.lastModified(), QDateTime(QDate(1601, 1, 1), QTime(1, 0), Qt::UTC).toLocalTime());
#endif
} }
void tst_QFileInfo::isSymLink_data() void tst_QFileInfo::isSymLink_data()