1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qdockarealayout.cpp: add comments to apply(bool aninmate) bool traps

Browse Source 
apply() of various classes sadly take a boolean argument, to indicate
whether an animation should be triggered.
Removing this bool trap would require central enumeration.

At least document in apply() calls, what the boolean argument is for.

Task-number: QTBUG-136716
Pick-to: 6.8 6.5
Change-Id: I5de59fb2813207c09d9de3cfb9ca147c18d943de
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit bf38ab9990f30151c148dbff77c8c9bf3982f097)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Axel Spoerl 2025-05-13 10:31:47 +02:00 committed by Qt Cherry-pick Bot
parent 9e9c951387
commit cde02af8f6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/widgets/widgets/qdockarealayout.cpp
View File

@ -3365,7 +3365,7 @@ int QDockAreaLayout::separatorMove(const QList<int> &separator, const QPoint &or
else
setGrid(&list, nullptr);
apply(false);
apply(/* animate = */ false);
return delta;
}
@ -3379,7 +3379,7 @@ int QDockAreaLayoutInfo::separatorMove(const QList<int> &separator, const QPoint
delta = pick(info->o, dest - origin);
if (delta != 0)
delta = info->separatorMove(index, delta);
info->apply(false);
info->apply(/* animate = */ false);
return delta;
}