From cd1ef4db4f817f8fd6d4810abb5a64158a5f90e4 Mon Sep 17 00:00:00 2001 From: Edward Welbourne Date: Wed, 7 Jun 2023 16:25:59 +0200 Subject: [PATCH] XBEL example: Fix null dereference bug As readXBEL() does call readSeparator(nullptr), the latter should cope with being passed nullptr as item. Task-number: QTBUG-111228 Change-Id: I786e4438b566438448b5d54ff6442c27f1255aa8 Reviewed-by: Ievgenii Meshcheriakov (cherry picked from commit 705e4e63c6ce26507d930428b8cf0d0f137bf3e5) --- examples/corelib/serialization/streambookmarks/xbelreader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/corelib/serialization/streambookmarks/xbelreader.cpp b/examples/corelib/serialization/streambookmarks/xbelreader.cpp index 2d3248e9362..9075631673d 100644 --- a/examples/corelib/serialization/streambookmarks/xbelreader.cpp +++ b/examples/corelib/serialization/streambookmarks/xbelreader.cpp @@ -82,7 +82,7 @@ void XbelReader::readSeparator(QTreeWidgetItem *item) Q_ASSERT(xml.isStartElement() && xml.name() == QLatin1String("separator")); QTreeWidgetItem *separator = createChildItem(item); - separator->setFlags(item->flags() & ~Qt::ItemIsSelectable); + separator->setFlags(item ? item->flags() & ~Qt::ItemIsSelectable : Qt::ItemFlags{}); separator->setText(0, QString(30, u'\xB7')); xml.skipCurrentElement(); }