From ccd0ea0b4e402f02dee73c211d62cef70d3e001f Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 26 Mar 2025 22:04:03 +0100 Subject: [PATCH] tst_QButtonGroup: fix memleak in keyNavigationPushButtons() While a QButtonGroup is-a QObject, unless it has a QObject-parent, it won't be deleted by, say, the parent of the buttons it contains, so this test function leaked the QButtonGroup. Fix by giving it the dialog as parent. This is just a QObject parent-child relationship; it does not change the behavior of the button group, nor the dialog, except that the latter now deletes the former as its QObject child when it itself it deleted. Amends e7cff5bca7aefaea63e80598babf6bd7917aa1c3. Pick-to: 6.9 6.8 6.5 5.15 Change-Id: Ic633179252c72e7ee47a57be73944a6aa589637b Reviewed-by: Axel Spoerl --- tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp b/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp index a1d27ed4a55..46eb4416bf5 100644 --- a/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp +++ b/tests/auto/widgets/widgets/qbuttongroup/tst_qbuttongroup.cpp @@ -197,7 +197,7 @@ void tst_QButtonGroup::keyNavigationPushButtons() layout->addWidget(pb3); layout->addWidget(le2); - QButtonGroup *buttonGroup = new QButtonGroup; + QButtonGroup *buttonGroup = new QButtonGroup(&dlg); buttonGroup->addButton(pb1); buttonGroup->addButton(pb2); buttonGroup->addButton(pb3);