From cb1489314c7313873530104be95d66ffd39c019e Mon Sep 17 00:00:00 2001 From: Dennis Oberst Date: Mon, 31 Jul 2023 13:49:31 +0200 Subject: [PATCH] Use new QBA::assign in QStorageInfoPrivate::retrievePosixInfo QByteArray::assign() re-uses existing unshared capacity(), if any, and is therefore potentially more efficient than '= QByteArray(~)' (and never slower). Task-number: QTBUG-106201 Change-Id: Ic51fc57eb0f84d3624ad3447c93a74241ab3612b Reviewed-by: Thiago Macieira Reviewed-by: Marc Mutz (cherry picked from commit b40bb99a60dcccb1dcbb72ac3d3349607d5b3358) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/io/qstorageinfo_mac.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/io/qstorageinfo_mac.cpp b/src/corelib/io/qstorageinfo_mac.cpp index 690e7212d12..38f86c3f7d5 100644 --- a/src/corelib/io/qstorageinfo_mac.cpp +++ b/src/corelib/io/qstorageinfo_mac.cpp @@ -43,9 +43,9 @@ void QStorageInfoPrivate::retrievePosixInfo() QT_STATFSBUF statfs_buf; int result = QT_STATFS(QFile::encodeName(rootPath).constData(), &statfs_buf); if (result == 0) { - device = QByteArray(statfs_buf.f_mntfromname); + device.assign(statfs_buf.f_mntfromname); readOnly = (statfs_buf.f_flags & MNT_RDONLY) != 0; - fileSystemType = QByteArray(statfs_buf.f_fstypename); + fileSystemType.assign(statfs_buf.f_fstypename); blockSize = statfs_buf.f_bsize; } }