1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

AndroidTestRunner: fix failure to acquire test runner semaphore

Browse Source 
Currently, if the test runner is interrupted by SIGINT and SIGTERM,
the semaphore is never released and thus consecutive test runner
executions will wait forever. To fix that, a signal handler for the
former signals is added to release the QSystemSemaphore. Also,
remove RunnerLocker and simply use QSystemSemaphore directly,
and explicitly release the semaphore at the end of the test runner
execution.

Fixes: QTBUG-115298
Pick-to: 6.5
Change-Id: I4f6cc0e4d837460de9a66248e09d3cbaf24ce959
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
Reviewed-by: Zoltan Gera <zoltan.gera@qt.io>
(cherry picked from commit 20643d17bfe6266ff6582c944ccd9d35fbbe5048)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Assam Boudjelthia 2023-11-25 12:57:31 +02:00 committed by Qt Cherry-pick Bot
parent 751d80f126
commit ca80d4ff09
1 changed files with 41 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/tools/androidtestrunner/main.cpp
View File

@ -11,6 +11,8 @@
#include <algorithm>
#include <functional>
#include <atomic>
#include <csignal>
#include <QtCore/QDeadlineTimer>
#include <QtCore/QThread>
#include <QtCore/QProcessEnvironment>
@ -512,20 +514,6 @@ static bool pullFiles()
return ret;
}
struct RunnerLocker
{
RunnerLocker()
{
runner.acquire();
}
~RunnerLocker()
{
runner.release();
}
QSystemSemaphore runner{ QSystemSemaphore::platformSafeKey(u"androidtestrunner"_s),
1, QSystemSemaphore::Open };
};
void printLogcat(const QString &formattedTime)
{
QString logcatCmd = "%1 logcat "_L1.arg(g_options.adbCommand);
@ -617,8 +605,41 @@ static QString getCurrentTimeString()
return QString::fromUtf8(output.simplified());
}
struct TestRunnerSystemSemaphore
{
TestRunnerSystemSemaphore() { }
~TestRunnerSystemSemaphore() { release(); }
void acquire() { isAcquired.store(semaphore.acquire()); }
void release()
{
bool expected = true;
// NOTE: There's still could be tiny time gap between the compare_exchange_strong() call
// and release() call where the thread could be interrupted, if that's ever an issue,
// this code could be checked and improved further.
if (isAcquired.compare_exchange_strong(expected, false))
isAcquired.store(!semaphore.release());
}
std::atomic<bool> isAcquired { false };
QSystemSemaphore semaphore { QSystemSemaphore::platformSafeKey(u"androidtestrunner"_s),
1, QSystemSemaphore::Open };
};
TestRunnerSystemSemaphore testRunnerLock;
void sigHandler(int signal)
{
std::signal(signal, SIG_DFL);
testRunnerLock.release();
}
int main(int argc, char *argv[])
{
std::signal(SIGINT, sigHandler);
std::signal(SIGTERM, sigHandler);
QCoreApplication a(argc, argv);
if (!parseOptions()) {
printHelp();
@ -656,7 +677,9 @@ int main(int argc, char *argv[])
obtainSDKVersion();
RunnerLocker lock; // do not install or run packages while another test is running
// do not install or run packages while another test is running
testRunnerLock.acquire();
if (!execCommand(QStringLiteral("%1 install -r -g %2")
.arg(g_options.adbCommand, g_options.apkPath), nullptr, g_options.verbose)) {
return 1;
@ -694,5 +717,8 @@ int main(int argc, char *argv[])
res &= execCommand(QStringLiteral("%1 uninstall %2").arg(g_options.adbCommand, g_options.package),
nullptr, g_options.verbose);
fflush(stdout);
testRunnerLock.release();
return res ? 0 : 1;
}