1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QSctpSocket: replace QList with const array

Browse Source 
"Never use a dynamically-sized container for statically-sized data."

Port the loop from Q_FOREACH (which can't deal with arrays) to ranged
for (which can).

Task-number: QTBUG-115839
Change-Id: Iecfc037c8bbfc0b3196ed0c65f680768a8d2353a
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
(cherry picked from commit 3b6ae86ce8a1d45e735c748f1cc766d9c592755a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2023-08-08 07:37:03 +02:00 committed by Qt Cherry-pick Bot
parent 5bae58bb45
commit c9d8bcb9dd
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/auto/network/socket/qsctpsocket/tst_qsctpsocket.cpp
View File

@ -127,12 +127,13 @@ void tst_QSctpSocket::bind_data()
// these ranges are guaranteed to be reserved for 'documentation purposes', // these ranges are guaranteed to be reserved for 'documentation purposes',
// and thus, should be unused in the real world. Not that I'm assuming the // and thus, should be unused in the real world. Not that I'm assuming the
// world is full of competent administrators, or anything. // world is full of competent administrators, or anything.
QStringList knownBad; const QString knownBad[] = {
knownBad << "198.51.100.1"; "198.51.100.1",
knownBad << "2001:0DB8::1"; "2001:0DB8::1",
foreach (const QString &badAddress, knownBad) { };
for (const QString &badAddress : knownBad)
QTest::newRow(badAddress.toLatin1().constData()) << badAddress << false << QString(); QTest::newRow(badAddress.toLatin1().constData()) << badAddress << false << QString();
}
} }
// Testing bind function // Testing bind function