1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QProcess/Unix: speed up initialization of write notifier

Browse Source 
By using new QSocketNotifier API, we can avoid unnecessarily enabling
the notifier right before turning it off again.

Change-Id: Ie0dea00251e9885653677c495dfc5abaaa4db1c7
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
This commit is contained in:
Alex Trotsenko 2020-12-14 19:10:17 +02:00
parent f2d22d5a51
commit c773fd297a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/corelib/io/qprocess_unix.cpp
View File

@ -259,9 +259,8 @@ bool QProcessPrivate::openChannel(Channel &channel)
// create the socket notifiers // create the socket notifiers
if (threadData.loadRelaxed()->hasEventDispatcher()) { if (threadData.loadRelaxed()->hasEventDispatcher()) {
if (&channel == &stdinChannel) { if (&channel == &stdinChannel) {
channel.notifier = new QSocketNotifier(channel.pipe[1], channel.notifier = new QSocketNotifier(QSocketNotifier::Write, q);
QSocketNotifier::Write, q); channel.notifier->setSocket(channel.pipe[1]);
channel.notifier->setEnabled(false);
QObject::connect(channel.notifier, SIGNAL(activated(QSocketDescriptor)), QObject::connect(channel.notifier, SIGNAL(activated(QSocketDescriptor)),
q, SLOT(_q_canWrite())); q, SLOT(_q_canWrite()));
} else { } else {