From c76d1a975348cf5f950a4cef6962f5024bc78c35 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 30 May 2025 12:00:35 -0300 Subject: [PATCH] tst_QTimer: delete XPASSing flaky test This is fixed in Qt 6.10/dev, by one of many changes affecting the event loop and threading, so it's not obvious which one. It's been flaky on 6.9 for the GUI Glib event loop and has been XPASS'ing. 1133: ********* Start testing of tst_QGuiTimer ********* XPASS : tst_QGuiTimer::crossThreadSingleShotDestruction(1s) 'deadTimerDestroyed' returned TRUE unexpectedly. () Loc: [/home/qt/work/qt/qtbase/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp(1328)] Pick-to: 6.8 Change-Id: Ibbe5373a1f36eaab9830fffdac20c042682c583e Reviewed-by: Volker Hilsheimer --- tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp b/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp index 91415c3dbbf..e84464cd3ff 100644 --- a/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp +++ b/tests/auto/corelib/kernel/qtimer/tst_qtimer.cpp @@ -1321,10 +1321,7 @@ void tst_QTimer::crossThreadSingleShotDestruction() QVERIFY(!timer); } -# if defined(Q_OS_DARWIN) || defined(Q_OS_WIN) || defined(Q_OS_QNX) || defined(DISABLE_GLIB)|| defined(QT_NO_GLIB) || defined(QT_GUI_LIB) - QEXPECT_FAIL("1s", "Events posted to a thread after event loop exit are leaking.", - Continue); -# endif + return; // Events posted to a thread after event loop exit are leaking. QVERIFY(deadTimerDestroyed); } #endif