From c5da2e6f063e262c8e9ea96793728be79fd09737 Mon Sep 17 00:00:00 2001 From: Laszlo Agocs Date: Wed, 29 Jul 2020 17:59:55 +0200 Subject: [PATCH] Remove old qsb versions from qshader autotest Only keep 3, 4, and 5 because 3 is the lowest version where binary JSON is not used anymore. Change-Id: Id0319e8eceb845017ed493d0ef6902b53050d5a6 Reviewed-by: Sona Kurazyan Reviewed-by: Edward Welbourne Reviewed-by: Laszlo Agocs --- tests/auto/gui/rhi/qshader/data/README | 15 ------------ .../rhi/qshader/data/color_all_v1.vert.qsb | Bin 1847 -> 0 bytes .../rhi/qshader/data/color_all_v5.vert.qsb | Bin 0 -> 1491 bytes .../rhi/qshader/data/color_spirv_v1.vert.qsb | Bin 813 -> 0 bytes .../rhi/qshader/data/color_spirv_v5.vert.qsb | Bin 0 -> 544 bytes .../rhi/qshader/data/texture_all_v2.frag.qsb | Bin 1691 -> 0 bytes tests/auto/gui/rhi/qshader/tst_qshader.cpp | 22 +++++++++--------- 7 files changed, 11 insertions(+), 26 deletions(-) delete mode 100644 tests/auto/gui/rhi/qshader/data/README delete mode 100644 tests/auto/gui/rhi/qshader/data/color_all_v1.vert.qsb create mode 100644 tests/auto/gui/rhi/qshader/data/color_all_v5.vert.qsb delete mode 100644 tests/auto/gui/rhi/qshader/data/color_spirv_v1.vert.qsb create mode 100644 tests/auto/gui/rhi/qshader/data/color_spirv_v5.vert.qsb delete mode 100644 tests/auto/gui/rhi/qshader/data/texture_all_v2.frag.qsb diff --git a/tests/auto/gui/rhi/qshader/data/README b/tests/auto/gui/rhi/qshader/data/README deleted file mode 100644 index 3d89f2a0c52..00000000000 --- a/tests/auto/gui/rhi/qshader/data/README +++ /dev/null @@ -1,15 +0,0 @@ -Warning: Do NOT regenerate the .qsb files without proper planning and understanding -the following. - -Among other things, we are also testing backwards compatibility for QShader -deserialization. - -.qsb files with _v1 in the name were produced with an older qtshadertools -and have a QSB_VERSION of 1. - -Files with _v2 are generated with a newer qsb, those have QSB_VERSION 2. -The difference is the support for nativeResourceBindingMap() which is only -present in v2. - -Files with _v3 come from an even newer qsb, and have QSB_VERSION 3. The -difference to 2 is the use of CBOR instead of binary JSON for QShaderDescription. diff --git a/tests/auto/gui/rhi/qshader/data/color_all_v1.vert.qsb b/tests/auto/gui/rhi/qshader/data/color_all_v1.vert.qsb deleted file mode 100644 index 7d02d823d2fce92a77b685fbff28dd94a86ef5f8..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 1847 zcmV-72gvvU03vsIob6f7Z`4K6O$0g2cd+*KvLKRnmS}#P(o1os1hnv5J9L? zK(2S!8w|VlVtYdZ&5>I#t$L_Pk3CiW1Nv|Df2gV+dg!5ts#2xCH}h zv={zHva#JR)^L5B{B^h3E=t>DFfPEjO}6J?{Ivzw!uTA<9$Mp}4#ZVA1J7Qbhd&j-yQai7&FV`H(ChEQ`f;mO-wHzCheVux z`w8fc^r-6vdz42`F`uJce#Q{5jOj>Pjh)*t%XY9rc0*s!nc}0neO||?4#T)+_5x_y*__^+z%?_#rF|5+Y3nXhq68q9hs}TX^TqhrhM(gn4uT= zhc)set`#&@U8GSztVE=7ZdjKYz_1sti#6k><=wHoz*@$6S>iL2g&Q;jzV;Cx?+4+E zfy#p2LE>YDWI;MeYX~!mz7GH`Ba8Dh0)M>wAr^%92-%t?yhq5^9Lx!E?TK{Kg4ZGB zF^&xBhx902RbGzbIH%x6y${LmAlaQI?8g;cNFP(^5e4@E%<2&Gw8$pjAAmdTxg5qY z=;xU1!D+$kgbI=O$e$*YKo5{DXmAeK6d-X%j*|NhuE^D&nXuv!aqv*8R18IOo`n)be~n^1;Vu5`w`ke+{bCnmw>|c zoKW<~6upxqdnP&nV|ki;Qki>7nOh)#r%1O={{tfRF^hhwpGKG9y%Y8|pPbaSQM+2P zs(kjkap~4&!@qChORP~doyDfPXc@(`I&_JL+NiZ0SdN(WFRFZsd)A|-?O8AhUWu!% zF06*>nSmt?Sf1gQ9$4kTZ|9-C=6VNO&0K+FLY`j1`3%?3aA@8WMZLi39iBsT)1GP^ ze)tB=p&3pKO1!Ib>V?zVD#tcBt!ZG8ga-|9Gg08SBegcv(Li6-DJP^WUp5{C)6aE=!yDL ztD;41{0S&Vo ze^Jw#K4u0_k3NLj;$jx8PoC+N?1&H)mp92!JPX0;21HVw8)b|yEHr(~!zep?;od#P zS}_r@g@rImsI<<$?IfT@A%%Hn0Eh5WGqCb44yYg!Diej!{E~Qii{Z<=eCQ4XYtnZ(kGL;#^<uu2%4{%UYpW&@4kGIsc zp$606?c}Dd@)K`audbQ5tISy8+#BBQxBgD~+8+)vyrh;=4sX&k1kd#q7X8;E`z1Qv zP3U@?C&A{2AE*-Lyc8aVmP~I2A2iA1P}E%$2cQJ^zdGMW5x}#qzFi{_3%2bs4`aBj ld>HyZj^)`M@~vR|)Wa*?5n&c_NBpsy#sBZF{s-q$5_NXsqP_qC diff --git a/tests/auto/gui/rhi/qshader/data/color_all_v5.vert.qsb b/tests/auto/gui/rhi/qshader/data/color_all_v5.vert.qsb new file mode 100644 index 0000000000000000000000000000000000000000..4b8d71bcc3fd7da00088e9253cfaee4626121eb9 GIT binary patch literal 1491 zcmV;^1uXgi03Ek@ob6fbP8(McKE7aJ6QJP|+LDq(NE4ext_g0b;(~~hh@^@{6e?87 zLMvmh>9+Q+vlj!6_}K^OJMCzG{^^P{uiGu#sc5a*5is*DyI%9q*BW0gaMO~g zftXT&Df5o)n#cv~UE6FxSf-UPP>kdTG{_V(_gnf)QUU=+R)lWwCB@XSrePY<7LCb+ zC^4CtI_NYFNA&C=cZ_}0^$aJ!R|@<(_JQ86eGQ&PUdo4M;YUY54>=_18@t(b4KH6W z71aC*5G64IEEi-}VIUw2buz4WrV9j*B3+i@_p!d^dkOPl>;tUFx(%4^9VH3J!AyYZ>*=SR4sE}c z5BhdL9JGR%61_po+18UP4$0j&bQ9Zw@4&MnDk@QQq7YO>G%h0ks7I2~CnBkB3qpca zPBGrw*zD=SM(GNtl9=3v=Q~!y(XqN<@M$Ou=9f%*aTs@)5%}T6y$0(lCHAHNp5dqHx;r8HY(bPiab zIq=6A=EHDyAkD@h>g9;fNJhB=d?wt7u{{l6m@0tIiZ(tlZGavUH1>g(weWo%Xq;P8 ze@Mh13^npLDc*UqwMp^LldWf<6U22T#AF07E#y%gLxd0LMf$3|Vanq(C0@jBklksr zyGgO%QsP2-L80fAxTioXE#w(7n%KS$tsHzgyt9BG7I~IuCkJ|j+Q_dEJ*vnxiZ76B zl!Fx68zXyJ5r@pl80k)sopI8gpnfB72Iy-P7uvc<^d$A=U7)APmb5K%JVpM{{tWeT zn(WVr{z@LoXQ@3!^!wy%jPOX$5fA0_6dTGvfw4)m=x|5=ufW0aU86i+rCh9obd=~v zfS48W%UC7}k1@PQ{58tk4f6jz=pg+8VQ!EejOQlhY?A!kB;0Qh^`|28a39E02=t_f z7fq|)@*4*KtZjI;mJZ9kW$vwO5#Kf2jgRnG@vC*XLb#^2&#hY9aAEZrTxeDLTt>oU z_M{65X<=|B+_?H5In}D~!eI`#4Xaex-5q%BRI9;?MNp4@(;9GKR;xA7bId*8Gx7-s z!KtZ2mJ5OTuGp5M@MS9>xWgM!wHh2AySw+nm<6OI@^nX>WdM*@7vZ@O-sA#{_^$Cc z$1)~6b_ST1dS2N*XNhu=0%-i;q9enWCk3w9A>ov!`e8Ij*w5j$bNRtpT|2uq=LjcK z{OTFzICj~LasQR;C1#*O-$VvV|CGo!^a9c7<838&c9j^?L2Nm~a~g{j z#lJ}LGm0PS+e+>}q;^h`7bvFlUg@C?jQbY#`4LdqpF0Zvwt~A$vhTzWz*wGi?<%@W zif)1YEfMxFDoYTg_up2Qf3vdecT-VOtCykvOrXVu1wiVZB?&n=Rpp9ROX<8;u94u} t)+1^SoXF+*s(~*+F0-uXUsmDY78w0wGEx8a$P<6LJ5k=F|0n!GuF#o@@CECf;dxNzapjfvm6_YA#0R+b#@oX7pncfNZs5m}^u_ROo= ziv1X*g0&Mbj>5!9ax@PVZE9JVTY*Va9yX`_K6&-hpjN8 zzRR)Xr0er~!7-VLH6^*TW_jM@)@{W7LcmhS%%>syQS zM2V&QyHpE0ji7TlXit6gFHns)KV}j()p||DKNPsW?YC=w#B+U@bNUK<0~?kZXEV&J zT}`6kcn|*?;M+IO%BJ>F7j>mPpLy79#(t9ap3QSz9K1$dWyG8pc%t_b44!t+%3U>fzV(wS6#34UI_Ieu6Cf{`B*erbM4G_VA( zD0o@LLu*o$y<>tiDtpIdZjMdDpAcS*bzS_D%rXPNELa*_Yh0Foj6W$edV)Wx=G8II zPs?{%{8{N$lzR3n665@WaO3g0CS>QwbzJ zhvX#K&*R)?_9z6z&|NysEA*m-UA5qOjzE|;pL~xvsH3^_VU#WrzzML ztV_vkRkIk+bfV^|@Dg3^f}dXbo2L&K?r{|>e>0jy^Jr;Ua~;xn9{ohV%ts%m%g@tg zGW{wxKIa$4qSY*!MYrGw+u^C*!g;m60XsBX*J2X`=M3u|qIf)+C3n{Q5O}Q#mY*~I zaavqwLA^cJ8d7hMwJwm8>Z)uxf%$xk?{wtIPw@%Qtgpa1US#wtZ@{`O)*Vv&^NcRV z&oa21(cMIrZ}GrhQ|&`od7ORh4)_I|v-`vMfs3@&|CYFviI=G_jh8tCkM*jo7n%+? zlPYuTtW#rdo%dE>8~A{_wALwcgLioZ++;0R+s(Miep0AqOm5znbnfTMU_1rJ(K0S8>Lp$3<* zXF&t6%Xn@<8=83SLx8&9fO2{lTN_&j+YM|B*hZk@xHZRZ;PrHx0=rhr1~A}uXs+4Y zVaK-*W6UH3b_ntD#30>pr)`tJz-qOdwqIO6JemX;2FGo8!l2Dq znv7ut+ZwiqIJQw}dQ~fQJU5OrJse{iV@%7Q=hp~BCdQD0ExTF-8UI~uXQS9T!bg6a zW#?-f3P4zt&R)lTw7ZWW?<1y1bA-|Bgan>(6aGzXUo!qHFNr?`b>C_%dri-W>3;0< zG4?YN_HzLHq2oGr&u^Va-?swzA)(?w#q)Owx(~3OQ1SI#cJnk$aVuo}Ie|z*rBg@w zqYUY{>{iA0X0?HpJZ6FIG`3Z2*SRh-%TU96AVZTwV#}LQRc}+vT=~-cy z*Mi3FgK^|6x4W(%Yj~&gG!KH%?^Ht~F9jV*o}Q<(=xYtzjfC<`_ny-|yuOR=MMAoz zGQq3Fr*WjjuQOZ7Jywf2d9q;4IQ5!c7Z+B|b63xs!KOutG@F*&=vWQgoG%t|?6-^= zoRYRHt^Pq(EC}De-En*yjj$~0{UPkO)ELT+PYfTiQ=hCQ^RX(zCK%846WljoN0YLV4d zHu5L%yS^TTRL+jOu`w&Eo{L>q4)i_AG%Db4-Bz$>qXZReXC#aztu|0KN}tl@0@75< zD4>Dz9jTY=7IB1<+M>8~Pce$Uyj~))x4d$b?ejm28iU z)T-#Ws-i$n9GZ>|CkPRJr4V8Fy|2ucbrbP*>w+Sh-QqwqS}oK{nynUcdbLPZ2G^%J zpHsQy@fBAT?ejgnYmmY@G$<=}%OS2N!i*KoC?T3bKn7T7IG3xtO0v{*qkkrIb(XJO zx_ZrA_Pro5FVWk_-etNV);_+zeEIU#l|oN}>n<+Kmw>(I$bu+eGuJG?VTbHOt|z2m z?zyOF6{D!h4j^UVI%DeV%x;uw9ot2Kh^7=?M|gA^7IlSu52+D!9*hzU2&^2a7bc~o zOM2#umQAhhdmY@<7g2haey=@2f9XC!=T5zTg8mOr&{yPPNqMgEnNBC-JQoT^+qbKZ z>}@)Y&9-8rv`g%`;h@LkzvnX&DffFYxMle}#P&;3)@YiaAZsgDXss7EV%~}?|Ao12 zZHD|5Ggo{)L-xw(tC>sSS-?l~X>w?0gi<_$JIxa;9mjWqgxs$U%kzcR@@gL6CG+#A z=!F3e;0_14Fb<++ir+<}7#ZmU;1KGic%zcU54~wTOVA!F)uW%r581>!StX-=Xgp3O z8}G{0jy;Wj>AwrwL=EHTD32lDLDHTsE#-ta+U*gB3GA!g7mgA8gdyU9`V{}2zW&?n zhx+51{zdFZvD31j?)GQ8I?dVb==vC5 z(f<(w+XU*5fck$TC1okhG)P^Nm$;u{*(6>Wte=41BkE71Chg@7_809z#@HYA_p^-R zA7p<+tbYii+EMz{A7|N{*gwM9Qj%ZA>k;-r_Q%-QQMNxO<3zF)`cPvhe;;svlKW&o z#k%D0Bjlg|9Fqre@B$^2!$p+Rm=5rG7I`d(8SfXUH6nAMbVz;qsbVersion, 1); + QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 5); QCOMPARE(s.availableShaders().count(), 1); const QShaderCode shader = s.shader(QShaderKey(QShader::SpirvShader, @@ -148,11 +148,11 @@ void tst_QShader::simpleCompileCheckResults() void tst_QShader::genVariants() { - QShader s = getShader(QLatin1String(":/data/color_all_v1.vert.qsb")); + QShader s = getShader(QLatin1String(":/data/color_all_v5.vert.qsb")); // spirv, glsl 100, glsl 330, glsl 120, hlsl 50, msl 12 // + batchable variants QVERIFY(s.isValid()); - QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 1); + QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 5); QCOMPARE(s.availableShaders().count(), 2 * 6); int batchableVariantCount = 0; @@ -173,9 +173,9 @@ void tst_QShader::genVariants() void tst_QShader::shaderDescImplicitSharing() { - QShader s = getShader(QLatin1String(":/data/color_spirv_v1.vert.qsb")); + QShader s = getShader(QLatin1String(":/data/color_spirv_v5.vert.qsb")); QVERIFY(s.isValid()); - QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 1); + QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 5); QCOMPARE(s.availableShaders().count(), 1); QVERIFY(s.availableShaders().contains(QShaderKey(QShader::SpirvShader, QShaderVersion(100)))); @@ -211,9 +211,9 @@ void tst_QShader::shaderDescImplicitSharing() void tst_QShader::bakedShaderImplicitSharing() { - QShader s0 = getShader(QLatin1String(":/data/color_spirv_v1.vert.qsb")); + QShader s0 = getShader(QLatin1String(":/data/color_spirv_v5.vert.qsb")); QVERIFY(s0.isValid()); - QCOMPARE(QShaderPrivate::get(&s0)->qsbVersion, 1); + QCOMPARE(QShaderPrivate::get(&s0)->qsbVersion, 5); QCOMPARE(s0.availableShaders().count(), 1); QVERIFY(s0.availableShaders().contains(QShaderKey(QShader::SpirvShader, QShaderVersion(100)))); @@ -262,9 +262,9 @@ void tst_QShader::bakedShaderImplicitSharing() void tst_QShader::mslResourceMapping() { - QShader s = getShader(QLatin1String(":/data/texture_all_v2.frag.qsb")); + QShader s = getShader(QLatin1String(":/data/texture_all_v4.frag.qsb")); QVERIFY(s.isValid()); - QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 2); + QCOMPARE(QShaderPrivate::get(&s)->qsbVersion, 4); const QList availableShaders = s.availableShaders(); QCOMPARE(availableShaders.count(), 7); @@ -430,7 +430,7 @@ void tst_QShader::comparison() { QShader s1 = getShader(QLatin1String(":/data/texture_all_v4.frag.qsb")); QVERIFY(s1.isValid()); - QShader s2 = getShader(QLatin1String(":/data/color_all_v1.vert.qsb")); + QShader s2 = getShader(QLatin1String(":/data/color_all_v5.vert.qsb")); QVERIFY(s2.isValid()); QVERIFY(s1.description().isValid());