1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add fixme note to QWindowPrivate::setVisible about visibility during create

Browse Source 
Change-Id: I71cb5b560538887f85d92178ff17eaaecaf06904
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Tor Arne Vestbø 2020-07-19 22:10:52 +02:00
parent 5b1befa31a
commit bd143f7df3
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/gui/kernel/qwindow.cpp
View File

@ -354,8 +354,14 @@ void QWindowPrivate::setVisible(bool visible)
return;
// We only need to create the window if it's being shown
if (visible)
if (visible) {
// FIXME: At this point we've already updated the visible state of
// the QWindow, so if the platform layer reads the window state during
// creation, and reflects that in the native window, it will end up
// with a visible window. This may in turn result in resize or expose
// events from the platform before we have sent the show event below.
q->create();
}
}
if (visible) {