From ba465f00edf361693b675229aa1dc7cee973fa81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Nordheim?= Date: Thu, 24 Sep 2020 16:38:27 +0200 Subject: [PATCH] QList: Remove CapacityReserved on squeeze Even if we don't reallocate or detach. Change-Id: I44928c261f037b304de8ee6135b96f00dd217c51 Reviewed-by: Thiago Macieira Reviewed-by: Andrei Golubev Reviewed-by: Giuseppe D'Angelo Reviewed-by: Oswald Buddenhagen --- src/corelib/tools/qlist.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/corelib/tools/qlist.h b/src/corelib/tools/qlist.h index 3f621e71fb9..f93b60d4bbd 100644 --- a/src/corelib/tools/qlist.h +++ b/src/corelib/tools/qlist.h @@ -528,6 +528,9 @@ inline void QList::squeeze() detached->copyAppend(constBegin(), constEnd()); } d.swap(detached); + } else { + // We're detached so this is fine + d->clearFlag(Data::CapacityReserved); } }