1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use Qt 5's QStringList::join(QChar)

Browse Source 
Less typing and less cycles than join(QString) where appropriate

Change-Id: I6ebc0e17e4d7fd9845864dd95b7de4ba4dad6906
Reviewed-by: Eike Ziller <eike.ziller@digia.com>
(cherry picked from qtcreator/6431ab2c799553623ec3fe6a79f1e85484558dd6)
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
This commit is contained in:
hjk 2014-08-23 01:19:53 +02:00 committed by Oswald Buddenhagen
parent 7b1a8e047c
commit ba2d6bb968
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qmake/library/qmakeglobals.cpp
View File

@ -197,11 +197,11 @@ QMakeGlobals::ArgumentReturn QMakeGlobals::addCommandLineArguments(
void QMakeGlobals::commitCommandLineArguments(QMakeCmdLineParserState &state) void QMakeGlobals::commitCommandLineArguments(QMakeCmdLineParserState &state)
{ {
if (!state.preconfigs.isEmpty()) if (!state.preconfigs.isEmpty())
state.precmds << (fL1S("CONFIG += ") + state.preconfigs.join(fL1S(" "))); state.precmds << (fL1S("CONFIG += ") + state.preconfigs.join(QLatin1Char(' ')));
precmds = state.precmds.join(fL1S("\n")); precmds = state.precmds.join(QLatin1Char('\n'));
if (!state.postconfigs.isEmpty()) if (!state.postconfigs.isEmpty())
state.postcmds << (fL1S("CONFIG += ") + state.postconfigs.join(fL1S(" "))); state.postcmds << (fL1S("CONFIG += ") + state.postconfigs.join(QLatin1Char(' ')));
postcmds = state.postcmds.join(fL1S("\n")); postcmds = state.postcmds.join(QLatin1Char('\n'));
if (xqmakespec.isEmpty()) if (xqmakespec.isEmpty())
xqmakespec = qmakespec; xqmakespec = qmakespec;