From b725daa449f2d82be2910e370f6cf265524ede0b Mon Sep 17 00:00:00 2001 From: Tim Blechmann Date: Thu, 8 Feb 2024 09:28:12 +0800 Subject: [PATCH] qmake: use [[fallthrough]] Since qt is on C++17, it's possible too use the [[fallthrough]] attribute instead of a // Fallthrough comment, that may be stripped by compiler launchers (ccache/icecc), causing -Wimplicit-fallthrough warnings. Change-Id: Ic809cf4e95b2160fac591b3802fa123e705337cc Reviewed-by: Marc Mutz (cherry picked from commit 84537e6dc22030004c2aec7285641e721da627cf) Reviewed-by: Qt Cherry-pick Bot --- qmake/generators/win32/msvc_objectmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmake/generators/win32/msvc_objectmodel.cpp b/qmake/generators/win32/msvc_objectmodel.cpp index b5639c01084..6517e5c4516 100644 --- a/qmake/generators/win32/msvc_objectmodel.cpp +++ b/qmake/generators/win32/msvc_objectmodel.cpp @@ -862,7 +862,7 @@ bool VCCLCompilerTool::parseOption(const char* option) } break; } - // Fallthrough + [[fallthrough]]; default: found = false; break; }