1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QGradient: optimize empty stops

Browse Source 
Don't allocate memory, use QList::fromReadOnlyData() over a static
constexpr array instead.

Change-Id: I596a3d61d5dd9603eea7f72a88d627af63ca54cd
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Marc Mutz 2021-07-12 17:47:21 +02:00
parent f3e006a698
commit b612014ae7
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/gui/painting/qbrush.cpp
View File

@ -1664,9 +1664,10 @@ void QGradient::setStops(const QGradientStops &stops)
QGradientStops QGradient::stops() const QGradientStops QGradient::stops() const
{ {
if (m_stops.isEmpty()) { if (m_stops.isEmpty()) {
QGradientStops tmp; static constexpr QGradientStop blackAndWhite[] = {
tmp << QGradientStop(0, Qt::black) << QGradientStop(1, Qt::white); {0, QColorConstants::Black}, {1, QColorConstants::White},
return tmp; };
return QGradientStops::fromReadOnlyData(blackAndWhite);
} }
return m_stops; return m_stops;
} }