From b57f7f07cf932bc61878473a492d7c39f15bcfbd Mon Sep 17 00:00:00 2001 From: Craig Scott Date: Fri, 17 Sep 2021 16:38:07 +1000 Subject: [PATCH] Remove unused EXE_FLAGS option from qt_internal_add_executable() The EXE_FLAGS option wasn't being used anywhere in any Qt repo and it had no documentation as to its intended use. Remove it. Pick-to: 6.2 Change-Id: I2f67ec57c1da7dc6eab81d5351361e770d19d7d5 Reviewed-by: Alexey Edelev Reviewed-by: Alexandru Croitor --- cmake/QtBuild.cmake | 1 - cmake/QtExecutableHelpers.cmake | 3 +-- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/cmake/QtBuild.cmake b/cmake/QtBuild.cmake index ec3f25ca4f4..cf79f3d9718 100644 --- a/cmake/QtBuild.cmake +++ b/cmake/QtBuild.cmake @@ -491,7 +491,6 @@ set(__qt_internal_add_executable_single_args ${__default_target_info_args} ) set(__qt_internal_add_executable_multi_args - EXE_FLAGS ${__default_private_args} ${__default_public_args} ) diff --git a/cmake/QtExecutableHelpers.cmake b/cmake/QtExecutableHelpers.cmake index b5fb18de4b2..75fe0d10dde 100644 --- a/cmake/QtExecutableHelpers.cmake +++ b/cmake/QtExecutableHelpers.cmake @@ -19,8 +19,7 @@ function(qt_internal_add_executable name) set(arg_INSTALL_DIRECTORY "${INSTALL_BINDIR}") endif() - # TODO: EXE_FLAGS doesn't seem to be used anywhere, we can probably remove it - _qt_internal_create_executable(${name} ${arg_EXE_FLAGS}) + _qt_internal_create_executable(${name}) if (ANDROID) qt_android_generate_deployment_settings("${name}") qt_android_add_apk_target("${name}")