1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Port some fallthrough comments to Q_FALLTHROUGH

Browse Source 
Change-Id: I70dd492d5c8d198589bfd642db63182cf17b133f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Giuseppe D'Angelo 2021-05-27 14:24:23 +02:00
parent 4059af81d3
commit b548c321d7
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/platforms/xcb/qxcbsessionmanager.cpp
View File

@ -242,7 +242,7 @@ static void sm_performSaveYourself(QXcbSessionManager *sm)
sm->appCommitData(); sm->appCommitData();
if (sm_isshutdown && sm_cancel) if (sm_isshutdown && sm_cancel)
break; // we cancelled the shutdown, no need to save state break; // we cancelled the shutdown, no need to save state
// fall through Q_FALLTHROUGH();
case SmSaveLocal: case SmSaveLocal:
sm->appSaveState(); sm->appSaveState();
break; break;

2
src/plugins/sqldrivers/mysql/qsql_mysql.cpp
View File

@ -1451,7 +1451,7 @@ QString QMYSQLDriver::formatValue(const QSqlField &field, bool trimStrings) cons
} else { } else {
qWarning("QMYSQLDriver::formatValue: Database not open"); qWarning("QMYSQLDriver::formatValue: Database not open");
} }
// fall through Q_FALLTHROUGH();
default: default:
r = QSqlDriver::formatValue(field, trimStrings); r = QSqlDriver::formatValue(field, trimStrings);
} }

4
src/plugins/sqldrivers/odbc/qsql_odbc.cpp
View File

@ -1676,7 +1676,7 @@ bool QODBCResult::exec()
ind); ind);
break; break;
} }
// fall through Q_FALLTHROUGH();
default: { default: {
QByteArray &ba = tmpStorage[i]; QByteArray &ba = tmpStorage[i];
if (*ind != SQL_NULL_DATA) if (*ind != SQL_NULL_DATA)
@ -1769,7 +1769,7 @@ bool QODBCResult::exec()
} }
break; break;
} }
// fall through Q_FALLTHROUGH();
default: { default: {
if (bindValueType(i) & QSql::Out) if (bindValueType(i) & QSql::Out)
values[i] = tmpStorage.at(i); values[i] = tmpStorage.at(i);