1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QGraphicsView: fix memleak

Browse Source 
Found by asan.

Amends 01aeb5f7e4fd977e9698fffdc7650897664ecb82.

Pick-to: 6.3 6.2 5.15
Change-Id: Id61fc1bc1f40494371ac27cb258a22c89db24683
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Marc Mutz 2022-01-05 08:10:26 +01:00
parent 08ea8aaa8b
commit b385632ea6
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/auto/widgets/graphicsview/qgraphicsview/tst_qgraphicsview.cpp
View File

@ -3548,10 +3548,10 @@ void tst_QGraphicsView::embeddedViewsWithFocus()
void focusOutEvent(QFocusEvent *) override { --focusCount; } void focusOutEvent(QFocusEvent *) override { --focusCount; }
}; };
QGraphicsScene *innerScene = new QGraphicsScene; QGraphicsScene innerScene;
FocusWidget *innerWidget = new FocusWidget; FocusWidget *innerWidget = new FocusWidget;
innerScene->addWidget(innerWidget); innerScene.addWidget(innerWidget);
QGraphicsView *innerView = new QGraphicsView(innerScene); QGraphicsView *innerView = new QGraphicsView(&innerScene);
QGraphicsScene outerScene; QGraphicsScene outerScene;
FocusWidget *outerWidget = new FocusWidget; FocusWidget *outerWidget = new FocusWidget;
@ -3569,7 +3569,7 @@ void tst_QGraphicsView::embeddedViewsWithFocus()
QCOMPARE(outerView.itemAt(outerCenter), outerProxy); QCOMPARE(outerView.itemAt(outerCenter), outerProxy);
QCOMPARE(outerView.itemAt(innerCenter), nestedProxy); QCOMPARE(outerView.itemAt(innerCenter), nestedProxy);
QVERIFY(outerScene.isActive()); QVERIFY(outerScene.isActive());
QVERIFY(innerScene->isActive()); QVERIFY(innerScene.isActive());
QCOMPARE(outerWidget->focusCount, 0); QCOMPARE(outerWidget->focusCount, 0);
QCOMPARE(innerWidget->focusCount, 0); QCOMPARE(innerWidget->focusCount, 0);