1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QByteArray::insert: do not assert that pos must be non-negative

Browse Source 
The insert() overloads have generally a very wide contract. The very
next line accepts negative positions, so remove the related assert.

Change-Id: I89b67615c59287825942047a28572bf896cf30e3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Giuseppe D'Angelo 2020-06-29 13:22:30 +02:00
parent 5fa016f284
commit b1ec50c96d
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/corelib/text/qbytearray.cpp
View File

@ -1911,8 +1911,6 @@ QByteArray& QByteArray::append(char ch)
static inline QByteArray &qbytearray_insert(QByteArray *ba, static inline QByteArray &qbytearray_insert(QByteArray *ba,
int pos, const char *arr, int len) int pos, const char *arr, int len)
{ {
Q_ASSERT(pos >= 0);
if (pos < 0 || len <= 0 || arr == nullptr) if (pos < 0 || len <= 0 || arr == nullptr)
return *ba; return *ba;