tst_QAccessibilityLinux: port away from Q_FOREACH
The single Q_FOREACH use here is simple, as it's over a local variable that just isn't marked as const due to the way it's constructed, and the loop body clearly doesn't modify the container, so the protective copy that Q_FOREACH performs is not needed. But std::as_const() is, to prevent a detach() (attempt). Add that. Task-number: QTBUG-115839 Change-Id: If228f649efd87388f6e312078b24a5b46ac8dc36 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com> Reviewed-by: David Faure <david.faure@kdab.com> (cherry picked from commit 5a8464b1f8fc88a47697012590dd4a8bb2201a61) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
parent
5d9c7c9e35
commit
b1d28854f2
@ -103,7 +103,7 @@ QStringList tst_QAccessibilityLinux::getChildren(QDBusInterface *interface)
|
||||
|
||||
Q_ASSERT(interface->property("ChildCount").toInt() == list.count());
|
||||
QStringList children;
|
||||
Q_FOREACH (const QSpiObjectReference &ref, list)
|
||||
for (const QSpiObjectReference &ref : std::as_const(list))
|
||||
children << ref.path.path();
|
||||
|
||||
return children;
|
||||
|
Loading…
x
Reference in New Issue
Block a user