diff --git a/tests/auto/tools/moc/tst_moc.cpp b/tests/auto/tools/moc/tst_moc.cpp index 05ad63e4ba4..2bc0cf18008 100644 --- a/tests/auto/tools/moc/tst_moc.cpp +++ b/tests/auto/tools/moc/tst_moc.cpp @@ -3131,10 +3131,10 @@ class AutoRegistrationObject : public QObject Q_PROPERTY(QWeakPointer customObjectWP READ customObjectWP CONSTANT) Q_PROPERTY(QPointer customObjectTP READ customObjectTP CONSTANT) Q_PROPERTY(QList listInt READ listInt CONSTANT) - Q_PROPERTY(QVector vectorVariant READ vectorVariant CONSTANT) + Q_PROPERTY(QList listVariant READ listVariant CONSTANT) Q_PROPERTY(QList listObject READ listObject CONSTANT) - Q_PROPERTY(QVector> vectorListInt READ vectorListInt CONSTANT) - Q_PROPERTY(QVector> vectorListObject READ vectorListObject CONSTANT) + Q_PROPERTY(QList> listListInt READ listListInt CONSTANT) + Q_PROPERTY(QList> listListObject READ listListObject CONSTANT) Q_PROPERTY(CustomQObject::Number enumValue READ enumValue CONSTANT) Q_PROPERTY(CustomQObjectStar customObjectTypedef READ customObjectTypedef CONSTANT) Q_PROPERTY(SomeNamespace::NamespacedQObject* customObjectNamespaced READ customObjectNamespaced CONSTANT) @@ -3175,25 +3175,16 @@ public: return QList(); } - QVector vectorVariant() const - { - return QVector(); - } + QList listVariant() const { return QList(); } QList listObject() const { return QList(); } - QVector > vectorListInt() const - { - return QVector >(); - } + QList> listListInt() const { return QList>(); } - QVector > vectorListObject() const - { - return QVector >(); - } + QList> listListObject() const { return QList>(); } CustomQObject::Number enumValue() const { @@ -3222,10 +3213,10 @@ public slots: void weakPointerSlot(QWeakPointer) {} void trackingPointerSlot(QPointer) {} void listIntSlot(QList) {} - void vectorVariantSlot(QVector) {} + void listVariantSlot(QList) { } void listCustomObjectSlot(QList) {} - void vectorListIntSlot(QVector >) {} - void vectorListCustomObjectSlot(QVector >) {} + void listListIntSlot(QList>) { } + void listListCustomObjectSlot(QList>) { } void enumSlot(CustomQObject2::Number) {} void typedefSlot(CustomQObject2Star) {} void namespacedQObjectSlot(SomeNamespace2::NamespacedQObject2*) {} @@ -3253,7 +3244,7 @@ void tst_Moc::autoPropertyMetaTypeRegistration() AutoRegistrationObject aro; static const int numPropertiesUnderTest = 15; - QVector propertyMetaTypeIds; + QList propertyMetaTypeIds; propertyMetaTypeIds.reserve(numPropertiesUnderTest); const QMetaObject *metaObject = aro.metaObject(); @@ -3266,23 +3257,17 @@ void tst_Moc::autoPropertyMetaTypeRegistration() } // Verify that QMetaProperty::userType gave us what we expected. - QVector expectedMetaTypeIds = QVector() - << QMetaType::QString // QObject::userType - << QMetaType::QObjectStar // AutoRegistrationObject::object - << qMetaTypeId() // etc. - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId > >() - << qMetaTypeId > >() - << qMetaTypeId() - << qMetaTypeId() - << qMetaTypeId() - << qMetaTypeId() - ; + QList expectedMetaTypeIds = QList() + << QMetaType::QString // QObject::userType + << QMetaType::QObjectStar // AutoRegistrationObject::object + << qMetaTypeId() // etc. + << qMetaTypeId>() + << qMetaTypeId>() << qMetaTypeId>() + << qMetaTypeId>() << qMetaTypeId>() + << qMetaTypeId>() << qMetaTypeId>>() + << qMetaTypeId>>() << qMetaTypeId() + << qMetaTypeId() << qMetaTypeId() + << qMetaTypeId(); QCOMPARE(propertyMetaTypeIds, expectedMetaTypeIds); } @@ -3303,7 +3288,7 @@ void tst_Moc::autoMethodArgumentMetaTypeRegistration() { AutoRegistrationObject aro; - QVector methodArgMetaTypeIds; + QList methodArgMetaTypeIds; const QMetaObject *metaObject = aro.metaObject(); @@ -3328,20 +3313,20 @@ void tst_Moc::autoMethodArgumentMetaTypeRegistration() ++i; \ } -#define FOR_EACH_SLOT_ARG_TYPE(F) \ - F(QObject*) \ - F(CustomQObject2*) \ - F(QSharedPointer) \ - F(QWeakPointer) \ - F(QPointer) \ - F(QList) \ - F(QVector) \ - F(QList) \ - F(QVector >) \ - F(QVector >) \ - F(CustomQObject2::Number) \ - F(CustomQObject2Star) \ - F(SomeNamespace2::NamespacedQObject2*) \ +#define FOR_EACH_SLOT_ARG_TYPE(F) \ + F(QObject *) \ + F(CustomQObject2 *) \ + F(QSharedPointer) \ + F(QWeakPointer) \ + F(QPointer) \ + F(QList) \ + F(QList) \ + F(QList) \ + F(QList>) \ + F(QList>) \ + F(CustomQObject2::Number) \ + F(CustomQObject2Star) \ + F(SomeNamespace2::NamespacedQObject2 *) \ F(SomeNamespace2::NamespacedNonQObject2) // Note: mulit-arg slots are tested below. @@ -3351,27 +3336,20 @@ void tst_Moc::autoMethodArgumentMetaTypeRegistration() #undef TYPE_LOOP #undef FOR_EACH_SLOT_ARG_TYPE - QVector expectedMetaTypeIds = QVector() - << QMetaType::QObjectStar - << qMetaTypeId() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId >() - << qMetaTypeId > >() - << qMetaTypeId > >() - << qMetaTypeId() - << qMetaTypeId() - << qMetaTypeId() - << qMetaTypeId() - ; + QList expectedMetaTypeIds = QList() + << QMetaType::QObjectStar << qMetaTypeId() + << qMetaTypeId>() + << qMetaTypeId>() + << qMetaTypeId>() << qMetaTypeId>() + << qMetaTypeId>() << qMetaTypeId>() + << qMetaTypeId>>() << qMetaTypeId>>() + << qMetaTypeId() << qMetaTypeId() + << qMetaTypeId() + << qMetaTypeId(); QCOMPARE(methodArgMetaTypeIds, expectedMetaTypeIds); - - QVector methodMultiArgMetaTypeIds; + QList methodMultiArgMetaTypeIds; { const QMetaMethod method = metaObject->method(i); @@ -3422,23 +3400,12 @@ void tst_Moc::autoMethodArgumentMetaTypeRegistration() ++i; } - QVector expectedMultiMetaTypeIds = QVector() - << QMetaType::Int - << qMetaTypeId() - << qMetaTypeId() - << QMetaType::Int - << qMetaTypeId() - << qMetaTypeId() - << qMetaTypeId() - << QMetaType::Int - << qMetaTypeId() - << QMetaType::Int - << qMetaTypeId() - << qMetaTypeId() - << QMetaType::Int - << qMetaTypeId() - << QMetaType::Int - ; + QList expectedMultiMetaTypeIds = QList() + << QMetaType::Int << qMetaTypeId() << qMetaTypeId() + << QMetaType::Int << qMetaTypeId() << qMetaTypeId() + << qMetaTypeId() << QMetaType::Int << qMetaTypeId() + << QMetaType::Int << qMetaTypeId() << qMetaTypeId() + << QMetaType::Int << qMetaTypeId() << QMetaType::Int; QCOMPARE(methodMultiArgMetaTypeIds, expectedMultiMetaTypeIds); @@ -3449,7 +3416,7 @@ void tst_Moc::autoSignalSpyMetaTypeRegistration() { AutoRegistrationObject aro; - QVector methodArgMetaTypeIds; + QList methodArgMetaTypeIds; const QMetaObject *metaObject = aro.metaObject(); @@ -3674,7 +3641,7 @@ void tst_Moc::relatedMetaObjectsInGadget() void tst_Moc::relatedMetaObjectsNameConflict_data() { - typedef QVector QMetaObjects; + typedef QList QMetaObjects; QTest::addColumn("dependingObject"); QTest::addColumn("relatedMetaObjects"); @@ -3705,7 +3672,7 @@ void tst_Moc::relatedMetaObjectsNameConflict_data() void tst_Moc::relatedMetaObjectsNameConflict() { - typedef QVector QMetaObjects; + typedef QList QMetaObjects; QFETCH(const QMetaObject*, dependingObject); QFETCH(QMetaObjects, relatedMetaObjects); @@ -3886,7 +3853,8 @@ void tst_Moc::optionsFileError() #endif } -static void checkEnum(const QMetaEnum &enumerator, const QByteArray &name, const QVector> &keys) +static void checkEnum(const QMetaEnum &enumerator, const QByteArray &name, + const QList> &keys) { QCOMPARE(name, QByteArray{enumerator.name()}); QCOMPARE(keys.size(), enumerator.keyCount());