1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QFileDialog::saveFileContent crashes on accept

Browse Source 
When using QFileDialog::saveFileCOntent, there is a risk of crash.

Using deleteLater in the dialogClosed lambda in QFileDialog::saveFileContent

Pick-to: 5.15
Fixes: QTBUG-90442
Change-Id: I200ccda9d973af2fa9b6ce9d72a518b154ef2019
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
This commit is contained in:
Dong Rui 2021-06-01 10:48:22 +08:00 committed by Morten Johan Sørvig
parent ee66bfba39
commit af738780d3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/widgets/dialogs/qfiledialog.cpp
View File

@ -2348,7 +2348,7 @@ void QFileDialog::getOpenFileContent(const QString &nameFilter, const std::funct
auto dialogClosed = [=](int code) { auto dialogClosed = [=](int code) {
Q_UNUSED(code); Q_UNUSED(code);
delete dialog; dialog->deleteLater();
}; };
connect(dialog, &QFileDialog::fileSelected, fileSelected); connect(dialog, &QFileDialog::fileSelected, fileSelected);
@ -2393,7 +2393,7 @@ void QFileDialog::saveFileContent(const QByteArray &fileContent, const QString &
auto dialogClosed = [=](int code) { auto dialogClosed = [=](int code) {
Q_UNUSED(code); Q_UNUSED(code);
delete dialog; dialog->deleteLater();
}; };
connect(dialog, &QFileDialog::fileSelected, fileSelected); connect(dialog, &QFileDialog::fileSelected, fileSelected);