From ae71a00c611ce07965d6a4e54e7a5aee3105da5e Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Mon, 17 Jun 2024 11:39:20 -0700 Subject: [PATCH] CMake: disable the GCC -Wstringop-overread warning-error everywhere MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We were doing it only for MinGW, but it's now showing up everywhere. Pick-to: 6.7 6.8 Change-Id: Ic0adfa808d28487a8303fffd17d9deab60f6cd0a Reviewed-by: Mårten Nordheim --- cmake/QtInternalTargets.cmake | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cmake/QtInternalTargets.cmake b/cmake/QtInternalTargets.cmake index 21670973246..37b66095367 100644 --- a/cmake/QtInternalTargets.cmake +++ b/cmake/QtInternalTargets.cmake @@ -46,13 +46,11 @@ function(qt_internal_set_warnings_are_errors_flags target target_scope) endif() if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.0.0") + # Ditto + list(APPEND flags -Wno-error=stringop-overread) + # We do mixed enum arithmetic all over the place: list(APPEND flags -Wno-error=deprecated-enum-enum-conversion -Wno-error=deprecated-enum-float-conversion) - - # GCC has some false positive, and it specifically comes through in MINGW - if (MINGW) - list(APPEND flags -Wno-error=stringop-overread) - endif() endif() if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "11.0.0" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "11.2.0")