1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix queue passed to vkQueuePresent

Browse Source 
We do not test actively test setups where a separate graphics and
present queue is used because there is no combined queue at all. (it
won't be tested because we neither want to nor have the possibility to
do so)

However, QVulkanWindow (unlike, say, QRhi's Vulkan backend) attempts
to support this. It turns out the argument passed to vkQueuePresent is
wrong: the present is to be submitted to the present queue. So fix
this up.

Fixes: QTBUG-73470
Change-Id: Ic9b589aba52e3326637216b98a074e27fdc3e3b9
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
(cherry picked from commit f0057f0269b805d21f33ca974253733ac093c373)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Laszlo Agocs 2022-01-19 19:10:38 +01:00 committed by Qt Cherry-pick Bot
parent b54e2c70c3
commit ac782945fc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/gui/vulkan/qvulkanwindow.cpp
View File

@ -2020,7 +2020,7 @@ void QVulkanWindowPrivate::endFrame()
// order to circumvent driver frame callbacks // order to circumvent driver frame callbacks
inst->presentAboutToBeQueued(q); inst->presentAboutToBeQueued(q);
err = vkQueuePresentKHR(gfxQueue, &presInfo); err = vkQueuePresentKHR(presQueue, &presInfo);
if (err != VK_SUCCESS) { if (err != VK_SUCCESS) {
if (err == VK_ERROR_OUT_OF_DATE_KHR) { if (err == VK_ERROR_OUT_OF_DATE_KHR) {
recreateSwapChain(); recreateSwapChain();